Skip to content

[Crazy RoboTaxi] Improve results leaderboards UI - #615

Open
aidanfnv wants to merge 3 commits into
dev/aidanf/game/crazy-robotaxi/live-editfrom
dev/aidanf/game/crazy-robotaxi/leaderboards
Open

aidanfnv wants to merge 3 commits into
dev/aidanf/game/crazy-robotaxi/live-editfrom
dev/aidanf/game/crazy-robotaxi/leaderboards

Conversation

@aidanfnv

@aidanfnv aidanfnv commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Split off from #553

  • Show the leaderboard while the player is entering their name.
  • Insert a qualifying unsaved result at its final rank with an empty driver name until it is saved.
  • Show the existing leaderboard even when the player does not qualify for it.
  • Maintain up to 10 entries for both Taxi scores and Race times.
  • Highlight the player’s qualifying row.
  • Measure leaderboard columns from their headers and displayed values.
  • Make the leaderboard at least half the viewport width while preserving the minimum width required by its contents.
  • Size the table height from its rows and make the table vertically scrollable when available space is limited.
  • Place PLAY AGAIN and RETURN TO MENU side by side on both results screens.
  • Support returning to the menu directly from the results screen.

@aidanfnv
aidanfnv added this pull request to stack #610 September 11, 2026 00:46
@copy-pr-bot

copy-pr-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no outstanding actionable findings.

Summary

The PR improves the Crazy RoboTaxi results screens and leaderboard behavior.

  • Displays existing standings while entering a qualifying result and inserts the pending result at its prospective rank.
  • Standardizes Taxi and Race leaderboards at ten entries and measures table columns from displayed content.
  • Constrains leaderboard height to the available viewport and enables scrolling in limited space.
  • Adds side-by-side PLAY AGAIN and RETURN TO MENU actions using the existing menu-return transition.
  • Adds gameplay and UI coverage for leaderboard limits, pending rows, constrained layouts, and result actions.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Game or race ends] --> B{Result qualifies?}
    B -->|Yes| C[Show persisted leaderboard plus pending blank-name row]
    C --> D[Save driver name]
    D --> E[Show persisted ranked leaderboard]
    B -->|No| E
    C --> F[Play again or return to menu]
    E --> F
Loading

Reviews (8) · Last reviewed commit: "[crazy-robotaxi] Bound initial leaderboa..."

Comment thread apps/crazy_robotaxi/crazy_robotaxi/ui.py Outdated
@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/leaderboards branch from af1d4a3 to 77ecb0f Compare September 11, 2026 02:30
@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/leaderboards branch from fcb819c to 077ac9a Compare September 11, 2026 23:10
@aidanfnv

Copy link
Copy Markdown
Collaborator Author

/ok to test 077ac9a

@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/leaderboards branch from 077ac9a to 0339f49 Compare September 12, 2026 00:26
@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/leaderboards branch from 0339f49 to 8d16db9 Compare September 12, 2026 01:30
@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/leaderboards branch from 8d16db9 to e8018c3 Compare September 14, 2026 16:40
@aidanfnv

Copy link
Copy Markdown
Collaborator Author

/ok to test e8018c3

@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/leaderboards branch from e8018c3 to ee26df0 Compare September 14, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant