Skip to content

[Crazy RoboTaxi] Add settings menus with persistent settings configs - #611

Open
aidanfnv wants to merge 7 commits into
dev/aidanf/game/crazy-robotaxi/map-course-previewsfrom
dev/aidanf/game/crazy-robotaxi/options
Open

aidanfnv wants to merge 7 commits into
dev/aidanf/game/crazy-robotaxi/map-course-previewsfrom
dev/aidanf/game/crazy-robotaxi/options

Conversation

@aidanfnv

Copy link
Copy Markdown
Collaborator

Closes #551
Closes #552

Split off from #553, this change adds the ability to load settings from file instead of relying on CLI.
The game loads each setting from a file, and falls back to defaults if not present in the file.
CLI args and flags act as overrides for those loaded values.

It also adds an options menu to the game for modifying and saving the file contents, with the option to restore defaults.

@aidanfnv
aidanfnv added this pull request to stack #610 September 10, 2026 23:52
@copy-pr-bot

copy-pr-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding previous findings or new blocking issues.

Summary

Adds persistent YAML settings and an Options menu for Crazy Robotaxi.

  • Loads sparse user configuration over runner defaults, with explicit CLI overrides kept separate from saved values.
  • Supports validated, atomic saves, reset-to-defaults, immediate presentation updates, and restart notices for other settings.
  • Normalizes live-edit dependencies and preserves terminal results when gameplay HUD overlays are hidden.
  • No new actionable issues were identified in the changes since the previous review. Tests were inspected but not executed.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Runner defaults] --> B[Load sparse user YAML]
  B --> C[Saved settings]
  C --> D[Apply explicit CLI overrides]
  D --> E[Normalize dependencies]
  E --> F[Configure application]
  C --> G[Options draft]
  G --> H{Save or discard}
  H -->|Save| I[Normalize and validate]
  I --> J[Atomically update YAML]
  J --> K[Apply presentation settings]
  J --> L[Show restart notice when needed]
  H -->|Discard| M[Return without changes]
Loading

Reviews (8) · Last reviewed commit: "[crazy-robotaxi] Isolate Options UI mode..."

Comment thread apps/crazy_robotaxi/crazy_robotaxi/settings.py
Comment thread apps/crazy_robotaxi/crazy_robotaxi/ui.py
Comment thread apps/crazy_robotaxi/crazy_robotaxi/application.py
Comment thread apps/crazy_robotaxi/crazy_robotaxi/settings.py
Comment thread apps/crazy_robotaxi/crazy_robotaxi/settings.py
Comment thread apps/crazy_robotaxi/crazy_robotaxi/application.py Outdated
Comment thread apps/crazy_robotaxi/crazy_robotaxi/settings.py Outdated
Comment thread apps/crazy_robotaxi/crazy_robotaxi/settings.py Outdated
@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/options branch 2 times, most recently from b24b959 to b7b27e8 Compare September 11, 2026 02:30
@aidanfnv

Copy link
Copy Markdown
Collaborator Author

/ok to test d89f461

@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/options branch from d89f461 to cb00317 Compare September 12, 2026 00:53
@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/options branch 2 times, most recently from adf4a38 to 2b52fee Compare September 14, 2026 16:40
@aidanfnv

Copy link
Copy Markdown
Collaborator Author

/ok to test 2b52fee

Add the reusable Options menu and authored YAML settings schema, including live-edit configuration and native DiT compatibility feedback.

Signed-off-by: Aidan Foster <aidanf@nvidia.com>
Normalize quoted strings and use declared annotations when converting nullable dtypes and newly appended dataclass presets.

Signed-off-by: Aidan Foster <aidanf@nvidia.com>
Hide gameplay overlays when the HUD is disabled while continuing to render terminal name entry and leaderboard screens.

Signed-off-by: Aidan Foster <aidanf@nvidia.com>
Reapply shared settings normalization after CLI overrides so item types activate the style and weather abilities they require.

Signed-off-by: Aidan Foster <aidanf@nvidia.com>
Run the runtime taxi configuration validation before persisting an Options draft so invalid rules cannot break the next startup.

Signed-off-by: Aidan Foster <aidanf@nvidia.com>
Do not expose or persist an alignment output directory that has no runtime consumer.

Signed-off-by: Aidan Foster <aidanf@nvidia.com>
Signed-off-by: Aidan Foster <aidanf@nvidia.com>
@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/options branch from 2b52fee to f81f23b Compare September 14, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Crazy Robotaxi] Add options menu and config file system [Crazy Robotaxi] Add in-game method for enabling/disabling live-edit features

1 participant