Skip to content

[Crazy RoboTaxi] Remove unused "variants" left over from old map system - #608

Open
aidanfnv wants to merge 3 commits into
mainfrom
dev/aidanf/game/crazy-robotaxi/map-format-cleanup
Open

aidanfnv wants to merge 3 commits into
mainfrom
dev/aidanf/game/crazy-robotaxi/map-format-cleanup

Conversation

@aidanfnv

Copy link
Copy Markdown
Collaborator

Split off from #553, this change removes the map "variants" used by interactive-drive and the pre-API-port Crazy RoboTaxi demo, but not the ported version.

The interactive-drive scenes used previously have different time-of-day and weather variants, and the new map system does not make use of them. Time-of-day can be handled by bundling a different first frame and prompt (we could make it easier in future by adding time-of-day "variants" back, but likely not in this form being removed), and weather is now handled with live-edit features (though, again, we could pre-bake "weather" variants).

This functionality should be re-added in some form later, but leaving it here in a non-functional state has led to confusion from AI agents and has added unnecessary churn when using them to edit maps or map-adjacent systems.

@copy-pr-bot

copy-pr-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@aidanfnv

Copy link
Copy Markdown
Collaborator Author

/ok to test db1eca4

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 3/5

The PR is not yet safe to merge because SwiftVR reports incorrectly attributed stage timings and automatic native-source acquisition can remain broken after an interrupted clone.

Summary

This PR removes Crazy RoboTaxi map variants and canonicalizes spawn conditioning, while subsequent changes add automatic OmniDreams native-source acquisition, windowed video decoding, shared profiling formatting, and SwiftVR metric plumbing.

  • Flattens map spawn image and prompt fields and simplifies compiled scene archives.
  • Removes the interactive-drive dependency from the game engine.
  • Downloads OmniDreams native dependencies automatically into the artifact directory.
  • Adds decode-time video windowing and SwiftVR stage metrics.
  • Two new correctness issues remain in profiling attribution and interrupted-download recovery.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Input[SwiftVR input chunk] --> Encode[Encoder]
  Encode --> Restore[Transformer restore]
  Restore --> Decode[Decoder]
  Decode --> Finalize[Finalize]
  Encode -->|record encode| Metrics[EventProfiler]
  Encode -->|current premature record diffuse| Metrics
  Decode -->|record decode| Metrics
  Finalize -->|record finalize| Metrics
Loading

Reviews (6) · Last reviewed commit: "[crazy-robotaxi] Remove legacy prompt ov..."

@aidanfnv
aidanfnv added this pull request to stack #610 September 10, 2026 23:17
@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/map-format-cleanup branch 4 times, most recently from e6649f1 to 95c4db4 Compare September 14, 2026 16:40
@aidanfnv

Copy link
Copy Markdown
Collaborator Author

/ok to test 95c4db4

@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/map-format-cleanup branch from 95c4db4 to b3d7a25 Compare September 14, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant