#199 - Account for TX transform overhead in MTU sizing#218
Draft
MikesRND wants to merge 1 commit into
Draft
Conversation
Signed-off-by: MikesRND <6515522+MikesRND@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #199.
This updates raw-engine MTU sizing so configured TX transform overhead is considered alongside RX sizing. It also refreshes the related docs and log wording so MTU behavior is described consistently for RX and TX.
Verification
git diff --checkgit clang-format --diff --style file HEAD -- include/daqiri/types.h src/engines/dpdk/daqiri_dpdk_engine.cpp src/engines/ibverbs/ daqiri_ibverbs_engine.cpp src/engines/ibverbs/daqiri_ibverbs_engine.hdaqiri_dpdk,daqiri_ibverbs, anddaqiri_commonin the project container with examples disabledpython3 scripts/check_doc_refs.pyNote: the full container image build currently fails before this change is compiled, in
examples/pool_ring_bench.cpp, with a DPDK/GCC SIMD flag mismatch around_mm_alignr_epi8fromrte_memcpy.h. The focused container build disables examples and verifies the changed DPDK, ibverbs, and common library targets.Recommended follow-up on target hardware.