skills: remove redundant concept-only skills#1487
Conversation
Both were thin concept-only skills whose content is fully covered by their paired API skills. Merged the unique content (required clarifying questions, problem types table, QP-not-supported note) into cuopt-routing-api-python and cuopt-server-api-python respectively, then deleted the standalone skills and updated all cross-references in AGENTS.md, cuopt-multi-objective-exploration, and cuopt-skill-evolution. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
/nvskills-ci |
CI Test Summary✅ All 0 test job(s) passed. |
📝 WalkthroughWalkthroughRemoves two skill directories and their references, then updates the remaining cuOpt skill docs, benchmarks, and signature bundles. ChangesSkill consolidation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
/nvskills-ci |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-multi-objective-exploration/skill-card.md`:
- Around line 18-19: The credential metadata in the skill card is inconsistent
because one field says the requirement is unknown while the other says none are
needed. Update the skill-card metadata so the “Requires API Key or External
Credential” and “Credential Type(s)” values both reflect the same state, using
the relevant skill card fields to indicate either no credentials are required or
that the requirement is unspecified.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: db66b6b3-fe51-47c8-bd4c-b9f630f4dd98
📒 Files selected for processing (12)
skills/cuopt-multi-objective-exploration/BENCHMARK.mdskills/cuopt-multi-objective-exploration/skill-card.mdskills/cuopt-multi-objective-exploration/skill.oms.sigskills/cuopt-routing-api-python/BENCHMARK.mdskills/cuopt-routing-api-python/skill-card.mdskills/cuopt-routing-api-python/skill.oms.sigskills/cuopt-server-api-python/BENCHMARK.mdskills/cuopt-server-api-python/skill-card.mdskills/cuopt-server-api-python/skill.oms.sigskills/cuopt-skill-evolution/BENCHMARK.mdskills/cuopt-skill-evolution/skill-card.mdskills/cuopt-skill-evolution/skill.oms.sig
✅ Files skipped from review due to trivial changes (1)
- skills/cuopt-routing-api-python/skill-card.md
| **Requires API Key or External Credential:** [Not Specified] <br> | ||
| **Credential Type(s):** [None identified] <br> |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Make the credential metadata consistent.
[Not Specified] conflicts with Credential Type(s): [None identified], so consumers cannot tell whether this skill is known to require no secrets or whether the requirement is still unknown. Pick one state and represent both fields consistently.
One possible fix if the skill does not require credentials
-**Requires API Key or External Credential:** [Not Specified] <br>
+**Requires API Key or External Credential:** [No] <br>
**Credential Type(s):** [None identified] <br> 📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| **Requires API Key or External Credential:** [Not Specified] <br> | |
| **Credential Type(s):** [None identified] <br> | |
| **Requires API Key or External Credential:** [No] <br> | |
| **Credential Type(s):** [None identified] <br> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-multi-objective-exploration/skill-card.md` around lines 18 - 19,
The credential metadata in the skill card is inconsistent because one field says
the requirement is unknown while the other says none are needed. Update the
skill-card metadata so the “Requires API Key or External Credential” and
“Credential Type(s)” values both reflect the same state, using the relevant
skill card fields to indicate either no credentials are required or that the
requirement is unspecified.
|
/ok to test 96c074f |
Remove
cuopt-routing-formulationandcuopt-server-common. Their content has been merged intocuopt-routing-api-pythonandcuopt-server-api-pythonrespectively.🤖 Generated with Claude Code