Skip to content

chore(ci): exclude NVSkills-generated files from trailing-whitespace hook #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
Jun 25, 2026
Merged

chore(ci): exclude NVSkills-generated files from trailing-whitespace hook #1465

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfc3faf
chore(ci): exclude skill-card.md from trailing-whitespace hook
ramakrishnap-nv Jun 25, 2026
ff7d038
chore(ci): exclude NVSkills-generated files from trailing-whitespace …
ramakrishnap-nv Jun 25, 2026
626ec5a
chore(ci): exclude NVSkills-generated files at top-level pre-commit e…
ramakrishnap-nv Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,21 @@
# SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

exclude: |
(?x)^(
skills/.*/skill\.oms\.sig|
skills/.*/skill-card\.md|
skills/.*/BENCHMARK\.md
)$

@jameslamb jameslamb Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be skills/.*? Wouldn't SKILL.md (for example) changing also change the signature?

@ramakrishnap-nv ramakrishnap-nv Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in that case we need to run CI which would generate new files and signature associated with it and push as commit, for reference #1460 (comment)

@ramakrishnap-nv ramakrishnap-nv Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ee81be4

@ramakrishnap-nv ramakrishnap-nv Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we want to follow guidelines on all other things that we write and control like SKILL.md or any other underlying references, only want to skip which are generated.

@jameslamb jameslamb Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok


repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: 'v6.0.0'
hooks:
- id: end-of-file-fixer
exclude: ^(datasets|helmchart)/.*\.(mps|json|yaml|yml|txt)$|^skills/.*/skill\.oms\.sig$
exclude: ^(datasets|helmchart)/.*\.(mps|json|yaml|yml|txt)$
- id: trailing-whitespace
exclude: ^datasets/.*\.(mps|json|yaml|yml|txt)$|^skills/.*/skill\.oms\.sig$
exclude: ^datasets/.*\.(mps|json|yaml|yml|txt)$
- id: check-builtin-literals
- id: check-executables-have-shebangs
- id: check-json
Expand Down