Skip to content

ci: validate caller cache matrix keys - #24117

Closed
vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:codex/validate-caller-cache-matrix-key
Closed

vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:codex/validate-caller-cache-matrix-key

Conversation

@vyasr

@vyasr vyasr commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Description

Validation-only PR for rapidsai/shared-actions#144. It uses rapidsai/shared-workflows#636 and temporarily allows the PR-scoped libcudf JIT caches to save, so the job logs expose the computed matrix-specific cache keys.

This PR must not merge.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@vyasr
vyasr marked this pull request as ready for review September 10, 2026 21:27
@vyasr
vyasr requested a review from a team as a code owner September 10, 2026 21:27
@vyasr vyasr added the ci label Sep 10, 2026
@vyasr

vyasr commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 16e5b2b9-1a94-480b-8787-f85120f43dda

📥 Commits

Reviewing files that changed from the base of the PR and between e78c254 and cf9761f.

📒 Files selected for processing (1)
  • .github/workflows/pr.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated internal continuous integration workflow configuration for C++ test validation.
    • Enabled writable caching during test runs to improve build efficiency.

Walkthrough

The pull request updates the reusable C++ test workflow revision and changes caching from read-only to writable for PR-scoped entries.

Changes

C++ test cache workflow

Layer / File(s) Summary
Update workflow revision and cache settings
.github/workflows/pr.yaml
The C++ test job uses the codex/validate-caller-cache-matrix-key workflow revision. It can save PR-scoped cache entries and exposes computed cache keys.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: bdice, jameslamb

Merge Risk: ⚪ Minimal · up to cf976

This validation-only change temporarily enables writable PR-scoped C++ caches to expose matrix-specific keys. No concrete correctness, security, availability, or data-integrity issue is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CI change: validating caller cache matrix keys.
Description check ✅ Passed The description accurately explains the validation-only CI purpose, workflow references, temporary cache behavior, and non-merge intent.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@vyasr

vyasr commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Closing, I can see enough conda-cpp-tests results to confirm that the cache keys are properly uniquified now.

@vyasr vyasr closed this Sep 10, 2026
@vyasr
vyasr deleted the codex/validate-caller-cache-matrix-key branch September 10, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant