test(aws): reject reachable prohibited storage routes#554
Draft
cdeyoung-mir wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Chris DeYoung <cdeyoung@mirantis.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Member
|
/ok to test 88d4ab4 |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-07-23 18:32:14 UTC | Commit: 88d4ab4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add detector-level negative coverage for the AWS storage L3 routing check used by the NCP SDN08 validation contract.
The fixture keeps every storage-host pair reachable while installing a more-specific transit-gateway route for one cross-subnet direction. The test verifies that reachability alone does not satisfy the direct-path requirement:
no_gateway_hopfails, only the truly local pairs count as direct, and the overall result is unsuccessful.Validation
uvx pre-commit run -a: passedRelated work
T-SDN08-01N