[None][test] Temporarily waive nine KV cache regressions on all platforms - #19384
Conversation
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. WalkthroughThe integration waiver list adds nine skipped tests for KV-cache manager, KV connector, and SWA scratch-reuse scenarios. Each entry references pull request 19382. ChangesIntegration test waivers
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The PR only suppresses nine identified KV-cache regression tests and changes no production code or dependencies, so it is mergeable. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot skip --comment "disable main break test cases" |
|
PR_Github #74265 [ skip ] triggered by Bot. Commit: |
|
PR_Github #74265 [ skip ] completed with state |
Dev Engineer Review
The change adds nine global
SKIPwaivers totests/integration/test_lists/waives.txt. The scope is limited to temporary KV cache regression suppression. The main risk is that these waivers hide failures until issue#19382is resolved and the entries are removed.QA Engineer Review
The change modifies only
tests/integration/test_lists/waives.txt. It adds two cached-token attribution test IDs and seven KV connector or scratch-reuse test IDs, all linked to#19382. Coverage verdict: needs follow-up because the affected tests are skipped until the underlying fix lands.Per-File QA Perspective
tests/integration/test_lists/waives.txt: Adds nine global waivers for KV cache manager attribution, connector-prefix scheduling and re-entry, and SWA scratch reuse tests. QA should verify the exact test IDs and remove the waivers after#19382is fixed.Description
Temporarily skip the nine KV cache fixture regressions on all platforms to unblock other PRs while the two-line fix in #19382 is validated and reviewed. Seven connector-prefix tests fail because their partial manager lacks
is_estimating_kv_cache; two cached-token attribution tests lackkv_connector_managerafter #18583 and #18762 landed together. See main pre-merge #60944.Add nine exact test IDs to
waives.txt, each linked to #19382, without GPU/stage qualifiers or whole-file skips. Remove these temporary entries once #19382 lands. This PR can merge independently of the fix.Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why.
PR follows the TRT-LLM coding guidelines.
Only the nine confirmed failing cases are waived.
No API, dependency, ownership, documentation, or architecture changes.
Reviewers are assigned according to CODEOWNERS.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.