Skip to content

[None][test] Temporarily waive nine KV cache regressions on all platforms - #19384

Merged
HuiGao-NV merged 1 commit into
NVIDIA:mainfrom
yizhang-nv:codex/waive-kv-cache-fixture-regressions
Sep 18, 2026
Merged

HuiGao-NV merged 1 commit into
NVIDIA:mainfrom
yizhang-nv:codex/waive-kv-cache-fixture-regressions

Conversation

@yizhang-nv

@yizhang-nv yizhang-nv commented Sep 18, 2026

Copy link
Copy Markdown
Member

Dev Engineer Review

The change adds nine global SKIP waivers to tests/integration/test_lists/waives.txt. The scope is limited to temporary KV cache regression suppression. The main risk is that these waivers hide failures until issue #19382 is resolved and the entries are removed.

QA Engineer Review

The change modifies only tests/integration/test_lists/waives.txt. It adds two cached-token attribution test IDs and seven KV connector or scratch-reuse test IDs, all linked to #19382. Coverage verdict: needs follow-up because the affected tests are skipped until the underlying fix lands.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Adds nine global waivers for KV cache manager attribution, connector-prefix scheduling and re-entry, and SWA scratch reuse tests. QA should verify the exact test IDs and remove the waivers after #19382 is fixed.

Description

Temporarily skip the nine KV cache fixture regressions on all platforms to unblock other PRs while the two-line fix in #19382 is validated and reviewed. Seven connector-prefix tests fail because their partial manager lacks is_estimating_kv_cache; two cached-token attribution tests lack kv_connector_manager after #18583 and #18762 landed together. See main pre-merge #60944.

Add nine exact test IDs to waives.txt, each linked to #19382, without GPU/stage qualifiers or whole-file skips. Remove these temporary entries once #19382 lands. This PR can merge independently of the fix.

Test Coverage

  • Pre-commit validation checks waiver formatting, duplicates, and that all test IDs exist in source.
  • The entries use the global waiver syntax, so they apply to every platform collecting the affected tests.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why.

  • PR follows the TRT-LLM coding guidelines.

  • Only the nine confirmed failing cases are waived.

  • No API, dependency, ownership, documentation, or architecture changes.

  • Reviewers are assigned according to CODEOWNERS.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c5ade9d8-7030-4f40-8ecc-b72460edf020

📥 Commits

Reviewing files that changed from the base of the PR and between b5011b1 and f7a3791.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


Walkthrough

The integration waiver list adds nine skipped tests for KV-cache manager, KV connector, and SWA scratch-reuse scenarios. Each entry references pull request 19382.

Changes

Integration test waivers

Layer / File(s) Summary
Add tracked test waivers
tests/integration/test_lists/waives.txt
Adds nine skip entries for KV-cache manager v2, KV connector prefix scheduling and re-entry, and SWA scratch reuse tests.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: bowenfu

Merge Risk: ⚪ Minimal · up to f7a37

The PR only suppresses nine identified KV-cache regression tests and changes no production code or dependencies, so it is mergeable.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies a test-only change that temporarily waives nine KV cache regressions. It follows the repository format with [None][test].
Description check ✅ Passed The description explains the purpose, affected regressions, waiver scope, test coverage, and cleanup plan. It includes the required Description, Test Coverage, and PR Checklist sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@HuiGao-NV
HuiGao-NV enabled auto-merge (squash) September 18, 2026 02:25
@HuiGao-NV

Copy link
Copy Markdown
Collaborator

/bot skip --comment "disable main break test cases"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #74265 [ skip ] triggered by Bot. Commit: f7a3791 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #74265 [ skip ] completed with state SUCCESS. Commit: f7a3791
Skipping testing for commit f7a3791

Link to invocation

@yizhang-nv
yizhang-nv requested a review from mzweilz September 18, 2026 02:47
@HuiGao-NV
HuiGao-NV merged commit ffddc5a into NVIDIA:main Sep 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants