[None][fix] Preserve KV transfer outcomes independently of polling - #19377
Draft
chienchunhung wants to merge 2 commits into
Draft
chienchunhung wants to merge 2 commits into
chienchunhung wants to merge 2 commits into
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #74244 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #74244 [ run ] completed with state
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit each native KV-transfer Attempt's logical outcome when the task/session changes state, rather than when it is first polled. A later cancellation, failure, or physical completion cannot rewrite an earlier Delivered/Failed/Cancelled result. Physical retirement and deadlines are unchanged.
Major changes
_LogicalOutcomes: serialize completion against session failure/cancellation; preserve original cause and local/peer cancellation origin.TaskHandle.poll(): observe the committed outcome while keeping report progress separate.Verification
AttributeErrors outside this patch: 20 leaf failures currently waived under NVBUG 6800223 / [None][fix] Initialize KV cache fixtures and unwaive nine cases on all platforms #19382, plus four failing suite wrappers. The focused suites above are green; the full pipeline is not.Based on
main@e72f70e99d. Size: 208 production + 318 test lines changed.