-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[None][test] Replace TinyLlama-1.1B-Chat-v1.0 with Qwen3-0.6B in tests #19178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xinhe-nv
wants to merge
19
commits into
NVIDIA:main
Choose a base branch
from
xinhe-nv:trtllm-15117
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8280b79
[None][test] Replace TinyLlama-1.1B-Chat-v1.0 with Qwen3-0.6B in tests
xinhe-nv 90c137e
[None][test] Split qwen_model_root out of llama_model_root, drop LoRA…
xinhe-nv 3e57935
[None][test] Finish renaming stale TinyLlama identifiers to Qwen3-0.6B
xinhe-nv da08d2a
[None][test] Inline Qwen3-0.6B path lookup in triton_server llmapi tests
xinhe-nv 44cb005
[None][test] Remove qwen_model_root fixture, inline the model path lo…
xinhe-nv 9f6cea3
Merge branch 'main' into trtllm-15117
xinhe-nv 2cf8c0e
[None][fix] Fix regressions from the TinyLlama->Qwen3-0.6B test migra…
xinhe-nv 98e3040
[None][fix] Restore test_llmapi_lora and its TinyLlama LoRA fixtures
xinhe-nv ad82cd0
[None][test] Restore LlamaForCausalLM coverage in DECODER_MODELS
xinhe-nv e32dc78
[None][fix] Update telemetry architectureClassName assertions to Qwen…
xinhe-nv a8a37a5
Merge branch 'main' into trtllm-15117
xinhe-nv da7d5d0
[None][fix] Drop stale TinyLlama param from two B200 disagg waives
xinhe-nv f84eab5
Merge branch 'main' into trtllm-15117
xinhe-nv 700b27d
[None][fix] Migrate disaggregated test_configs/*.yaml model field to …
xinhe-nv 4365f78
[None][test] Add capture script for test_disaggregated_simple_llama Q…
xinhe-nv 91691f7
[None][test] Drop test_disaggregated_simple_llama, obsoleted by test_…
xinhe-nv 7abad82
Merge branch 'main' into trtllm-15117
xinhe-nv 5fe940e
Merge branch 'main' into trtllm-15117
xinhe-nv 3efbb84
Merge branch 'main' into trtllm-15117
xinhe-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_cache_aware_balance.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_cache_reuse.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_conditional.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_conversation.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_conversation_workers.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_ctxpp2_genpp2.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_ctxpp2_gentp2.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_ctxpp4_genpp4.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_ctxpp4_gentp4.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_ctxtp2_genpp2.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_ctxtp2_gentp1.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_ctxtp2pp2_gentp2pp2.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_cuda_graph_padding.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_diff_max_tokens.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_gen_only.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_gen_only_bs1.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...s/integration/defs/disaggregated/test_configs/disagg_config_gen_only_insufficient_kv.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_gen_only_kv_cache_aware.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_load_balance.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_load_balancing.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_metrics.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_mixed.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_multi_orchestrator.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_ngram.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_overlap.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_overlap_gen_first.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/defs/disaggregated/test_configs/disagg_config_overlap_gen_first_pp4.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...ion/defs/disaggregated/test_configs/disagg_config_overlap_transceiver_runtime_python.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...ration/defs/disaggregated/test_configs/disagg_config_python_transceiver_host_offload.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment just above
DECODER_MODELSsays the list holds one representative per distinct architecture class, and the TinyLlama entry was theLlamaForCausalLMone — explicitly noted as also covering Mistral, which aliasesLlamaModel. With it gone, Qwen3 is the only entry left, soencode()single-prefill coverage loses the whole Llama/Mistral family rather than becoming redundant with the Qwen3 case the way the description reads.If it's TinyLlama specifically that's being retired rather than the class, pointing the param at another small Llama-family checkpoint would keep the representative intact. Failing that, the comment above the list should probably stop advertising a class the list no longer covers.
Non-blocking as far as I'm concerned if you'd rather handle the replacement checkpoint separately — but worth not losing silently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed properly in ad82cd0: restored the LlamaForCausalLM representative pointed at Llama-3.2-1B — a small Llama checkpoint I confirmed is already relied on elsewhere in this suite (kv_cache/test_kv_cache_v2_scheduler.py's TestKVCacheV2Llama), so it's a verified-to-exist path rather than a guess at a new NFS checkpoint. Added back the matching l0_a100.yml/llm_function_core.txt test-list entries. The comment above DECODER_MODELS now correctly lists both LlamaForCausalLM/Mistral and Qwen3ForCausalLM as covered again.