Skip to content

[None][docs] fix visual_gen README cosmos3 and qwen-edit example paths - #18966

Open
imitater-dou wants to merge 1 commit into
NVIDIA:mainfrom
imitater-dou:docs/fix-visual-gen-readme-cosmos3-qwen-edit-paths
Open

[None][docs] fix visual_gen README cosmos3 and qwen-edit example paths#18966
imitater-dou wants to merge 1 commit into
NVIDIA:mainfrom
imitater-dou:docs/fix-visual-gen-readme-cosmos3-qwen-edit-paths

Conversation

@imitater-dou

@imitater-dou imitater-dou commented Sep 9, 2026

Copy link
Copy Markdown

Summary

  • Retarget deleted examples/visual_gen/models/cosmos3_ti2v.py references to models/cosmos3/cosmos3.py (Cosmos3 example lives under models/cosmos3/).
  • Correct qwen-image-edit --visual_gen_args config from nonexistent configs/qwen-image-edit-2511-fp4-1gpu.yaml to configs/qwen-image-edit-2511-fp8-1gpu.yaml.

Verification

  • Confirmed at 96a25c48b258: tree has examples/visual_gen/models/cosmos3/cosmos3.py and configs/qwen-image-edit-2511-fp8-1gpu.yaml; no cosmos3_ti2v.py and no fp4 edit YAML.
  • cosmos3.py accepts --prompt and defaults --model to nvidia/Cosmos3-Nano.

Signed-off-by: ADou ikun3.1415927@gmail.com

Dev Engineer Review

Updated README commands to reference examples/visual_gen/models/cosmos3/cosmos3.py and the existing FP8 Qwen configuration. Removed references to deleted or nonexistent paths. No runtime code changed.

QA Engineer Review

No test changes.

Per-File QA Perspective

  • examples/visual_gen/README.md: Verify the commands from the examples/visual_gen directory. Confirm Cosmos3 generation, Qwen image editing with the FP8 configuration, and PNG, MP4, and AVI output formats.

Retarget deleted models/cosmos3_ti2v.py to models/cosmos3/cosmos3.py and
correct qwen-image-edit config from nonexistent fp4 YAML to fp8.

Signed-off-by: ADou <ikun3.1415927@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cbc52073-baf1-4bf6-b939-f7997f273365

📥 Commits

Reviewing files that changed from the base of the PR and between 96a25c4 and 5563561.

📒 Files selected for processing (1)
  • examples/visual_gen/README.md

Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review.


Walkthrough

The VisualGen README now uses the current Cosmos3 script, the FP8 Qwen image-edit configuration, and updated PNG, MP4, and AVI output-format guidance.

Changes

VisualGen README updates

Layer / File(s) Summary
Update VisualGen examples
examples/visual_gen/README.md
Cosmos3 commands now use models/cosmos3/cosmos3.py. The Qwen image-edit example uses the FP8 configuration. Output formats now specify PNG for images and MP4 or AVI for videos.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 55635

VisualGen documentation now points users to the current Cosmos3 script and supported FP8 Qwen image-edit configuration; no actionable current-head merge risk remains.

Suggested reviewers: bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies a documentation fix for the VisualGen Cosmos3 and Qwen image-edit example paths. It is concise and directly related to the changes.
Description check ✅ Passed The description explains the problem, the documentation changes, and the verification performed. It omits the template's exact Description, Test Coverage, and PR Checklist sections, but the required c…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants