[None][docs] fix VisualGen NVL72 config .yml → .yaml in blog25 - #18965
[None][docs] fix VisualGen NVL72 config .yml → .yaml in blog25#18965imitater-dou wants to merge 1 commit into
Conversation
The NVL72 recipe files live as .yaml on main; blog25 still linked .yml (404). Signed-off-by: ADou <ikun3.1415927@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. WalkthroughChangesDocumentation configuration links
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This documentation-only update corrects configuration filenames for benchmark and serving instructions, restoring the intended references without affecting runtime behavior. No merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
brnguyen2
left a comment
There was a problem hiding this comment.
Checked against the tree: both configs exist as .yaml, and a repo-wide grep for visual_gen/configs/*.yml comes back empty after this change, so all three stale sites are covered. The SERVER_CONFIG fix matters most — that one silently breaks the sbatch run, not just a link.
Summary
docs/source/blogs/tech_blog/blog25_Scaling_Video_Generation_Across_NVL72_Rack_with_TensorRT-LLM.mdstill points at VisualGen NVL72 recipe files with a.ymlsuffix. Onmainthose configs are.yaml, so the blob links andSERVER_CONFIGexport 404.Retarget three sites:
examples/visual_gen/configs/wan22_t2v_bf16_gb200_nvl72.yml→.yaml(link +export SERVER_CONFIG=...)examples/visual_gen/configs/cosmos3_t2v_bf16_gb200_nvl72.yml→.yamlRepro
At HEAD
96a25c48b258:Test plan
.yml→.yamlfor those two config basenames.yamlpaths resolve onmainDev Engineer Review
The blog now uses
.yamlpaths for the Wan2.2, Cosmos3, and serving configuration files. This restores valid blob links and alignsSERVER_CONFIGwith the filenames onmain. No runtime logic or performance behavior changed.QA Engineer Review
No test changes.
Per-File QA Perspective
docs/source/blogs/tech_blog/blog25_Scaling_Video_Generation_Across_NVL72_Rack_with_TensorRT-LLM.md: Verify that all updated.yamllinks resolve and that the documentedSERVER_CONFIGvalue matches the available recipe filename. The change affects documentation references only.