Skip to content

[None][docs] fix VisualGen NVL72 config .yml → .yaml in blog25 - #18965

Open
imitater-dou wants to merge 1 commit into
NVIDIA:mainfrom
imitater-dou:docs/blog25-visualgen-nvl72-yml-to-yaml
Open

[None][docs] fix VisualGen NVL72 config .yml → .yaml in blog25#18965
imitater-dou wants to merge 1 commit into
NVIDIA:mainfrom
imitater-dou:docs/blog25-visualgen-nvl72-yml-to-yaml

Conversation

@imitater-dou

@imitater-dou imitater-dou commented Sep 9, 2026

Copy link
Copy Markdown

Summary

docs/source/blogs/tech_blog/blog25_Scaling_Video_Generation_Across_NVL72_Rack_with_TensorRT-LLM.md still points at VisualGen NVL72 recipe files with a .yml suffix. On main those configs are .yaml, so the blob links and SERVER_CONFIG export 404.

Retarget three sites:

  • examples/visual_gen/configs/wan22_t2v_bf16_gb200_nvl72.yml.yaml (link + export SERVER_CONFIG=...)
  • examples/visual_gen/configs/cosmos3_t2v_bf16_gb200_nvl72.yml.yaml

Repro

At HEAD 96a25c48b258:

# stale (404)
curl -sI https://raw.githubusercontent.com/NVIDIA/TensorRT-LLM/main/examples/visual_gen/configs/wan22_t2v_bf16_gb200_nvl72.yml | head -1
curl -sI https://raw.githubusercontent.com/NVIDIA/TensorRT-LLM/main/examples/visual_gen/configs/cosmos3_t2v_bf16_gb200_nvl72.yml | head -1

# live (200)
curl -sI https://raw.githubusercontent.com/NVIDIA/TensorRT-LLM/main/examples/visual_gen/configs/wan22_t2v_bf16_gb200_nvl72.yaml | head -1
curl -sI https://raw.githubusercontent.com/NVIDIA/TensorRT-LLM/main/examples/visual_gen/configs/cosmos3_t2v_bf16_gb200_nvl72.yaml | head -1

# docs still cite .yml
rg -n 'wan22_t2v_bf16_gb200_nvl72\.yml|cosmos3_t2v_bf16_gb200_nvl72\.yml' \
  docs/source/blogs/tech_blog/blog25_Scaling_Video_Generation_Across_NVL72_Rack_with_TensorRT-LLM.md

Test plan

  • Confirm PR diff only touches blog25 and only changes .yml.yaml for those two config basenames
  • Confirm linked .yaml paths resolve on main

Dev Engineer Review

The blog now uses .yaml paths for the Wan2.2, Cosmos3, and serving configuration files. This restores valid blob links and aligns SERVER_CONFIG with the filenames on main. No runtime logic or performance behavior changed.

QA Engineer Review

No test changes.

Per-File QA Perspective

  • docs/source/blogs/tech_blog/blog25_Scaling_Video_Generation_Across_NVL72_Rack_with_TensorRT-LLM.md: Verify that all updated .yaml links resolve and that the documented SERVER_CONFIG value matches the available recipe filename. The change affects documentation references only.

The NVL72 recipe files live as .yaml on main; blog25 still linked .yml (404).

Signed-off-by: ADou <ikun3.1415927@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7977ad21-8658-418b-bf2f-5cc60e180730

📥 Commits

Reviewing files that changed from the base of the PR and between 96a25c4 and bc1fd80.

📒 Files selected for processing (1)
  • docs/source/blogs/tech_blog/blog25_Scaling_Video_Generation_Across_NVL72_Rack_with_TensorRT-LLM.md

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.


Walkthrough

Changes

Documentation configuration links

Layer / File(s) Summary
Update configuration references
docs/source/blogs/tech_blog/blog25_Scaling_Video_Generation_Across_NVL72_Rack_with_TensorRT-LLM.md
Three configuration references now use .yaml instead of .yml.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bc1fd

This documentation-only update corrects configuration filenames for benchmark and serving instructions, restoring the intended references without affecting runtime behavior. No merge-blocking risk remains.

Suggested reviewers: bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies a documentation fix for stale VisualGen NVL72 configuration extensions and follows the required [ticket][type] format.
Description check ✅ Passed The description explains the stale links, lists the affected configuration references, provides reproduction commands, and includes a relevant test plan. It does not use the template headings or inclu…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@brnguyen2 brnguyen2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked against the tree: both configs exist as .yaml, and a repo-wide grep for visual_gen/configs/*.yml comes back empty after this change, so all three stale sites are covered. The SERVER_CONFIG fix matters most — that one silently breaks the sbatch run, not just a link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants