Skip to content

[None][docs] retarget moved performance doc URLs in tech blogs - #18962

Open
imitater-dou wants to merge 1 commit into
NVIDIA:mainfrom
imitater-dou:docs/retarget-moved-performance-urls-094732
Open

[None][docs] retarget moved performance doc URLs in tech blogs#18962
imitater-dou wants to merge 1 commit into
NVIDIA:mainfrom
imitater-dou:docs/retarget-moved-performance-urls-094732

Conversation

@imitater-dou

@imitater-dou imitater-dou commented Sep 9, 2026

Copy link
Copy Markdown

Summary

Retarget three tech-blog absolute links that still pointed at the removed docs/source/performance/ tree:

  • blog04docs/source/developer-guide/perf-benchmarking.md#preparing-a-dataset
  • blog08docs/source/developer-guide/perf-analysis.md
  • blog09docs/source/legacy/performance/performance-tuning-guide/tuning-max-batch-size-and-max-num-tokens.md

Test plan

  • Confirmed old paths 404 on main
  • Confirmed new paths exist; blog04 anchor #preparing-a-dataset present
  • Docs-only; no code/runtime changes

Dev Engineer Review

The change updates three obsolete documentation links in tech blogs. No source code, APIs, configuration, or runtime behavior changed. The replacement paths and blog04 anchor exist.

QA Engineer Review

No test changes.

Per-File QA Perspective

  • blog04_Scaling_Expert_Parallelism_in_TensorRT-LLM.md: Documentation-only link change. Verify the dataset-preparation link opens the intended section.
  • blog08_Scaling_Expert_Parallelism_in_TensorRT-LLM_part2.md: Documentation-only link change. Verify the performance-analysis link resolves correctly.
  • blog09_Deploying_GPT_OSS_on_TRTLLM.md: Documentation-only link change. Verify the performance-tuning guide link resolves correctly.

Point blog04/blog08/blog09 absolute links at the live developer-guide
and legacy performance doc paths (docs/source/performance/ was removed).

Signed-off-by: ADou <ikun3.1415927@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b43b9ad7-a170-45a0-81e1-916ccd768acd

📥 Commits

Reviewing files that changed from the base of the PR and between 96a25c4 and f6c9948.

📒 Files selected for processing (3)
  • docs/source/blogs/tech_blog/blog04_Scaling_Expert_Parallelism_in_TensorRT-LLM.md
  • docs/source/blogs/tech_blog/blog08_Scaling_Expert_Parallelism_in_TensorRT-LLM_part2.md
  • docs/source/blogs/tech_blog/blog09_Deploying_GPT_OSS_on_TRTLLM.md

Included review availability: Your plan provides up to 12 included reviews per hour; 6 remain after this review.


Walkthrough

Three technical blog links now point to current documentation paths for dataset preparation, performance analysis, and CUDA out-of-memory guidance.

Changes

Documentation link updates

Layer / File(s) Summary
Update technical blog references
docs/source/blogs/tech_blog/blog04_Scaling_Expert_Parallelism_in_TensorRT-LLM.md, docs/source/blogs/tech_blog/blog08_Scaling_Expert_Parallelism_in_TensorRT-LLM_part2.md, docs/source/blogs/tech_blog/blog09_Deploying_GPT_OSS_on_TRTLLM.md
Updated three links to current developer or performance-tuning documentation paths.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f6c99

The technical blog links now direct readers to the current dataset-preparation, performance-analysis, and memory-tuning documentation. The updated targets are present and relevant, with no runtime or deployment impact.

Suggested reviewers: bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format and clearly describes the documentation link updates in the tech blogs.
Description check ✅ Passed The description explains the three link changes and includes a test plan with path and anchor verification. The repository checklist is not included, but the description is otherwise complete for this…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@brnguyen2 brnguyen2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally: all three targets exist on main and perf-benchmarking.md:135 provides the #preparing-a-dataset anchor. One leftover from the same doc move, if you want it in scope: .github/CODEOWNERS:195 still lists /docs/source/performance/perf-benchmarking.md, so @NVIDIA/trt-llm-perf-devs no longer gets auto-review on the file at its new path. The docs/source/performance/ references in release-notes.md are historical and should stay as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants