[None][docs] retarget moved performance doc URLs in tech blogs - #18962
[None][docs] retarget moved performance doc URLs in tech blogs#18962imitater-dou wants to merge 1 commit into
Conversation
Point blog04/blog08/blog09 absolute links at the live developer-guide and legacy performance doc paths (docs/source/performance/ was removed). Signed-off-by: ADou <ikun3.1415927@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 6 remain after this review. WalkthroughThree technical blog links now point to current documentation paths for dataset preparation, performance analysis, and CUDA out-of-memory guidance. ChangesDocumentation link updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The technical blog links now direct readers to the current dataset-preparation, performance-analysis, and memory-tuning documentation. The updated targets are present and relevant, with no runtime or deployment impact. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
brnguyen2
left a comment
There was a problem hiding this comment.
Verified locally: all three targets exist on main and perf-benchmarking.md:135 provides the #preparing-a-dataset anchor. One leftover from the same doc move, if you want it in scope: .github/CODEOWNERS:195 still lists /docs/source/performance/perf-benchmarking.md, so @NVIDIA/trt-llm-perf-devs no longer gets auto-review on the file at its new path. The docs/source/performance/ references in release-notes.md are historical and should stay as-is.
Summary
Retarget three tech-blog absolute links that still pointed at the removed
docs/source/performance/tree:blog04→docs/source/developer-guide/perf-benchmarking.md#preparing-a-datasetblog08→docs/source/developer-guide/perf-analysis.mdblog09→docs/source/legacy/performance/performance-tuning-guide/tuning-max-batch-size-and-max-num-tokens.mdTest plan
main#preparing-a-datasetpresentDev Engineer Review
The change updates three obsolete documentation links in tech blogs. No source code, APIs, configuration, or runtime behavior changed. The replacement paths and
blog04anchor exist.QA Engineer Review
No test changes.
Per-File QA Perspective
blog04_Scaling_Expert_Parallelism_in_TensorRT-LLM.md: Documentation-only link change. Verify the dataset-preparation link opens the intended section.blog08_Scaling_Expert_Parallelism_in_TensorRT-LLM_part2.md: Documentation-only link change. Verify the performance-analysis link resolves correctly.blog09_Deploying_GPT_OSS_on_TRTLLM.md: Documentation-only link change. Verify the performance-tuning guide link resolves correctly.