[None][docs] Remove ghost --topr from RocketKV example command - #18952
Open
imitater-dou wants to merge 1 commit into
Open
[None][docs] Remove ghost --topr from RocketKV example command#18952imitater-dou wants to merge 1 commit into
imitater-dou wants to merge 1 commit into
Conversation
The llm_sparse_attention.py CLI has no --topr flag; keep API topr docs. Signed-off-by: ADou <ikun3.1415927@gmail.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. WalkthroughThe RocketKV example command removes the ChangesRocketKV example
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The RocketKV example no longer shows an unsupported --topr option, aligning the documented command with the CLI. No merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--toprfrom the RocketKVllm_sparse_attention.pyexample command inexamples/sparse_attention/RocketKV.md--topr; APIRocketSparseAttentionConfig.toprdocs unchangedTest plan
examples/llm-api/llm_sparse_attention.pyargparse has no--toprRocketSparseAttentionConfigstill documents APItoprDev Engineer Review
The RocketKV example command no longer passes the unsupported
--topr 128CLI option. TheRocketSparseAttentionConfig.toprAPI documentation remains unchanged.QA Engineer Review
No test changes.
Per-File QA Perspective
examples/sparse_attention/RocketKV.md: Verify the example command without--topr. Documentation rendering still needs follow-up.