[None][docs] drop ghost --backend tensorrt from trtllm-eval docs - #18950
[None][docs] drop ghost --backend tensorrt from trtllm-eval docs#18950imitater-dou wants to merge 1 commit into
Conversation
trtllm-eval Click Choice for --backend is only ["pytorch"]; docs still told users to pass --backend tensorrt and that --model accepts pre-built TensorRT engines. Align docs/source/commands/trtllm-eval.rst and examples/trtllm-eval/README.md with live argparse after engine-backend removal. Signed-off-by: ADou <ikun3.1415927@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. WalkthroughThe documentation now states that Changestrtllm-eval documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The documentation now consistently removes unsupported TensorRT backend and engine guidance for trtllm-eval while retaining the supported PyTorch workflow. No current merge-readiness risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
trtllm-evalClick--backendChoice is only["pytorch"]and always constructsPyTorchLLM.--backend tensorrtand that--modelaccepts pre-built TensorRT engines (with--tokenizer). Both are stale after the TensorRT engine backend removal (seedocs/source/legacy/tensorrt-backend-removal.md).docs/source/commands/trtllm-eval.rstandexamples/trtllm-eval/README.md. Keep HF-or-local-checkpoint / PyTorch-only wording.Repro
Upstream
tensorrt_llm/commands/eval.py:Test plan
adfc41e--backend tensorrt, nopre-built TensorRT enginesSigned-off-by: ADou ikun3.1415927@gmail.com
Dev Engineer Review
The documentation now states that
trtllm-evalsupports only thepytorchbackend. It removes outdated guidance for TensorRT backends and pre-built TensorRT engines. No source code, API, configuration, or runtime behavior changed.QA Engineer Review
No test changes.
Per-File QA Perspective
docs/source/commands/trtllm-eval.rst: Documentation-only change. Verify that the supported backend guidance matches currenttrtllm-evalbehavior.examples/trtllm-eval/README.md: Documentation-only change. Verify that HF/local-checkpoint and PyTorch-only usage remains accurate.