Skip to content

[None][docs] fix longbench README Directory Structure sparse_attention→longbench - #18947

Open
imitater-dou wants to merge 1 commit into
NVIDIA:mainfrom
imitater-dou:fix-longbench-readme-dir-structure
Open

[None][docs] fix longbench README Directory Structure sparse_attention→longbench#18947
imitater-dou wants to merge 1 commit into
NVIDIA:mainfrom
imitater-dou:fix-longbench-readme-dir-structure

Conversation

@imitater-dou

@imitater-dou imitater-dou commented Sep 9, 2026

Copy link
Copy Markdown

Summary

  • examples/longbench/README.md Directory Structure still showed a top-level sparse_attention/ tree for the LongBench eval scripts.
  • On main, those files live under examples/longbench/; examples/sparse_attention/ now only contains RocketKV.md.
  • Rename the Directory Structure root from sparse_attention/ to longbench/. Docs-only; no code or flag changes.

Test plan

  • Confirmed examples/longbench/ contains eval_longbench_v1.py, README.md, requirements.txt
  • Confirmed examples/sparse_attention/ only has RocketKV.md
  • Diff is the single Directory Structure root rename

Dev Engineer Review

The change corrects the documented directory name in examples/longbench/README.md from sparse_attention/ to longbench/. It is documentation-only and introduces no code, configuration, API, or performance risk.

QA Engineer Review

No test changes.

Per-File QA Perspective

  • examples/longbench/README.md: The directory structure example now matches the repository layout. QA should verify that the documented paths remain accurate.

…n→longbench

The Directory Structure example still rooted the tree at sparse_attention/,
but the eval scripts live under examples/longbench/ on main
(examples/sparse_attention/ now only has RocketKV.md).

Signed-off-by: ADou <ikun3.1415927@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e8ab690a-7878-4d5d-8cce-ac2cab40f43c

📥 Commits

Reviewing files that changed from the base of the PR and between eca1022 and 7fafd55.

📒 Files selected for processing (1)
  • examples/longbench/README.md

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The README directory structure now uses longbench/ instead of sparse_attention/.

Changes

LongBench documentation

Layer / File(s) Summary
Update directory reference
examples/longbench/README.md
The README now references the longbench/ directory. Previously, it referenced sparse_attention/.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7fafd

The LongBench README now names the current longbench/ directory. This documentation-only correction has no runtime or deployment impact and is ready to merge.

Suggested reviewers: bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies a documentation fix and accurately states the directory rename from sparse_attention to longbench.
Description check ✅ Passed The description explains the documentation issue, the correction, and the verification steps. It does not include the template's explicit checklist, but it provides the required substantive informatio…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant