-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[None][test] Pin the float32 precision of the attention-plugin rotary table #18774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brnguyen2
merged 6 commits into
NVIDIA:main
from
brnguyen2:test/rope-frequency-table-precision
Sep 15, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
de3676a
[None][test] Pin the float32 precision of the attention-plugin rotary…
brnguyen2 8371662
Address trivial review comments
brnguyen2 1de4c9a
[None][chore] Document the fp32 rope-table precision intent at the bu…
brnguyen2 2193d00
[None][chore] Pin the rope-table fp32 dtype as an internal variable
brnguyen2 6995aa1
Address trivial review comments
brnguyen2 be07af5
[None][chore] Drop the dtype assertions from the rotary-table test
brnguyen2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.