Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 2, 2026 14:44
|
🌿 Preview your docs: https://nvidia-preview-pr-4120.docs.buildwithfern.com/openshell |
elezar
marked this pull request as draft
October 2, 2026 15:05
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate the shared conformance runner and scenarios under
tests/suites/conformance, alongside their behavior-grouped Cargo entry points. This implements the first consolidation step in the final RFC 0016 proposal (#3460) after standalone runner removal, while preserving existing assertions and test selection names.Stacked on #3866; the PR base is
codex/conformance-after-parity.Related Issue
Closes #4119. Part of #3954.
Changes
crates/openshell-conformancetotests/suites/conformance/supportand make it a member of the suite workspace. Retain the package name and lint policy; declare the process runner's required Tokio features explicitly.Effective capability discovery, distinct applicability/infrastructure outcomes, attributed completeness reporting, and further behavioral migrations remain follow-ups. The RFC remains a draft; this PR does not claim new conformance qualification or driver admission evidence.
Testing
cargo check.--locked.tests/artifacts.nixparses; architecture/skill inventory, reference, and public discovery checks pass.mise run pre-commitpassed before rebasing. Focused tests, Clippy, consumer compilation, and all lockfiles were verified again on the final base.nix develop -c mise run ciran out of disk space during unrelated root-workspace Rust compilation. The task's disposable root build output was cleaned afterward. Full CI is not reported as passing.Checklist