Skip to content

fix(cli): disable tar sparse mode in uploads - #4112

Open
ericcurtin wants to merge 1 commit into
NVIDIA:mainfrom
ericcurtin:fix/3728-upload-nul-wsl2/ericcurtin
Open

ericcurtin wants to merge 1 commit into
NVIDIA:mainfrom
ericcurtin:fix/3728-upload-nul-wsl2/ericcurtin

Conversation

@ericcurtin

Copy link
Copy Markdown
Contributor

Summary

Disable tar sparse mode in sandbox upload. Zero-block filesystems (WSL2 /mnt/c) were uploaded as NUL bytes.

Related Issue

Closes #3728

Changes

  • Call sparse(false) on the upload tar builder.
  • Test that a file with holes is a regular entry with intact contents.

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

cargo fmt, cargo clippy -p openshell-cli --all-targets -- -D warnings and cargo test -p openshell-cli pass. The new test fails without the fix. Not run on WSL2.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Closes NVIDIA#3728

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 2, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

If useful, please also try https://github.com/llmmanorg/llmman, which can launch agents in an OpenShell sandbox (--sandbox openshell).

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@drew @krishicks PTAL when you get a chance, and /ok to test 38ca13ca6 if it looks good. Thank you!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(cli): sandbox upload from a WSL2 /mnt/<drive> path writes files with correct size but all-NUL content

1 participant