test(python): synchronize interactive exec TTY readiness - #4076
Merged
matthewgrossman merged 2 commits intoOct 1, 2026
Merged
Conversation
Wait for the complete readiness marker before streaming stdin so PTY echo cannot split the separately written TTY flags. Preserve pipe stream separation and verify consumed stdin and both output sentinels in TTY mode. Fixes #4075 Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
matthewgrossman
marked this pull request as ready for review
October 1, 2026 21:33
matthewgrossman
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 1, 2026 21:33
drew
approved these changes
Oct 1, 2026
matthewgrossman
deleted the
codex/4075-python-interactive-tty/matthewgrossman
branch
October 1, 2026 21:59
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent a false failure in
test_sandbox_interactive_exec_honors_ttywhen PTY stdin echo lands between the shell's separate TTY flag writes. Wait for a complete output readiness marker before submitting stdin, so a successful terminal execution cannot turnTTTintoTTstreamed-stdin-sentinel\r\nT.CI Evidence
Observed in PR #4066's Branch E2E Checks on October 1, 2026, at SHA
6c4bb7614af2d86783e8a887b8915ef1520e94df:test_sandbox_interactive_exec_honors_ttyfailed because stdout containedTTstreamed-stdin-sentinel\r\nTinstead of contiguousTTT. All three TTY flags, consumed stdin, both output sentinels, and exit code zero were present. Suite result: 1 failed, 59 passed, 81 skipped.This was a pre-existing test race exposed on the PR branch; PR #4066 does not modify this test or the interactive runtime.
Changes
Testing
git diff --checkpass.mise run pre-commithook passes, including repository lint, formatting, license, protobuf, Helm, and SDK checks.The change is limited to this E2E test; the adjacent request-EOF/output-draining test remains intact.
Checklist