-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(helm): add sandbox UID and GID values #3947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ericcurtin
wants to merge
1
commit into
NVIDIA:main
Choose a base branch
from
ericcurtin:feat/2697-helm-sandbox-uid-gid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+112
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
deploy/helm/openshell/tests/gateway_sandbox_identity_test.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| suite: sandbox UID and GID | ||
| templates: | ||
| - templates/gateway-config.yaml | ||
| release: | ||
| name: openshell | ||
| namespace: my-namespace | ||
|
|
||
| tests: | ||
| - it: omits sandbox_uid and sandbox_gid by default | ||
| asserts: | ||
| - notMatchRegex: | ||
| path: data["gateway.toml"] | ||
| pattern: 'sandbox_uid|sandbox_gid' | ||
|
|
||
| - it: renders sandbox_uid and sandbox_gid as integers | ||
| set: | ||
| server.sandboxUid: 1500 | ||
| server.sandboxGid: 2000 | ||
| asserts: | ||
| - matchRegex: | ||
| path: data["gateway.toml"] | ||
| pattern: '(?m)^\s*sandbox_uid\s*=\s*1500$' | ||
| - matchRegex: | ||
| path: data["gateway.toml"] | ||
| pattern: '(?m)^\s*sandbox_gid\s*=\s*2000$' | ||
|
|
||
| - it: renders sandbox_uid alone | ||
| set: | ||
| server.sandboxUid: 1500 | ||
| asserts: | ||
| - matchRegex: | ||
| path: data["gateway.toml"] | ||
| pattern: '(?m)^\s*sandbox_uid\s*=\s*1500$' | ||
| - notMatchRegex: | ||
| path: data["gateway.toml"] | ||
| pattern: 'sandbox_gid' | ||
|
|
||
| - it: renders large IDs without scientific notation | ||
| set: | ||
| server.sandboxUid: 1000680000 | ||
| server.sandboxGid: 4294967294 | ||
| asserts: | ||
| - matchRegex: | ||
| path: data["gateway.toml"] | ||
| pattern: '(?m)^\s*sandbox_uid\s*=\s*1000680000$' | ||
| - matchRegex: | ||
| path: data["gateway.toml"] | ||
| pattern: '(?m)^\s*sandbox_gid\s*=\s*4294967294$' | ||
|
|
||
| - it: rejects a zero sandbox UID | ||
| set: | ||
| server.sandboxUid: 0 | ||
| asserts: | ||
| - failedTemplate: | ||
| errorPattern: "server.sandboxUid must be an integer between 1 and 4294967294" | ||
|
|
||
| - it: rejects a sandbox GID above the allowed range | ||
| set: | ||
| server.sandboxGid: 4294967295 | ||
| asserts: | ||
| - failedTemplate: | ||
| errorPattern: "server.sandboxGid must be an integer between 1 and 4294967294" | ||
|
|
||
| - it: rejects a non-numeric sandbox UID | ||
| set: | ||
| server.sandboxUid: abc | ||
| asserts: | ||
| - failedTemplate: | ||
| errorPattern: "server.sandboxUid must be an integer between 1 and 4294967294" | ||
|
|
||
| - it: rejects a fractional sandbox UID | ||
| set: | ||
| server.sandboxUid: 1500.5 | ||
| asserts: | ||
| - failedTemplate: | ||
| errorPattern: "server.sandboxUid must be an integer between 1 and 4294967294" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning — GATOR-6a07ea84-01 · Reject boolean sandbox identities
Summary: An operator can set
server.sandboxUid: trueorserver.sandboxGid: true; the numeric conversions both produce 1, so validation passes and Helm renders identity 1. This overrides SCC discovery, which can leave pods rejected on OpenShift or run them under an unintended system account elsewhere.Fix: Reject booleans before conversion, or allow-list supported numeric/string scalar kinds while preserving empty and null omission. Add a boolean rejection test for the shared helper.
Verify: Set either value to
true; rendering must fail with the documented integer-range error instead of producingsandbox_uid = 1orsandbox_gid = 1.Agent context
deploy/helm/openshell/templates/_helpers.tpl:389gateway-config.yaml:250andgateway-config.yaml:253