docs(mxc): clarify mapper schema versions (NVBug 6847154) - #3894
Merged
Merged
Conversation
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
prekshivyas
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 29, 2026 19:52
shailendra-nv
approved these changes
Sep 29, 2026
shailendra-nv
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the complete diff and surrounding mapper/live-request code at e889339. No blocking findings. The compatibility alias preserves coarse schema 0.7 while governed output and live requests remain on 0.8. Non-blocking suggestion: assert the literal coarse version in the regression test to catch accidental constant changes. Current checks are successful or skipped; native Windows jobs were skipped, and author-reported native tests were not independently rerun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify why the standalone coarse MXC policy mapper defaults to schema 0.7 while live driver and governed-egress requests use schema 0.8. Investigation showed that these values describe different artifacts and the reported runtime mismatch does not occur.
This PR preserves both behaviors and adds explicit naming, documentation, and regression coverage so the two schema contracts cannot be mistaken for competing live-runtime versions.
Related Issue
Reproduction and conclusion
Before this change,
DEFAULT_MXC_VERSIONin the coarse mapper was0.7.0-alpha, whileMXC_SCHEMA_VERSIONin the driver was0.8.0-alpha. Code-path and Git-history tracing showed this is intentional:allowedHosts.egress/ingress.EmbeddedPolicyMapperuses coarse JSON only as an intermediate translation and does not send its version towxc-exec.After this change, the values remain intentionally different, but the coarse constant is explicitly named and the distinct shapes are regression-tested.
Changes
DEFAULT_COARSE_MXC_VERSIONas the clear canonical name for the 0.7 coarse artifact.DEFAULT_MXC_VERSIONas a compatibility alias, with no public API break.allowedHostswhile governed/live 0.8 uses directionalegress.Testing
mise run pre-commitpassespolicy_mapper_matrix: 45 passed.wxc-execis not installed on this host. The existing ignored dry-run integration remains the real-binary contract check.cargo fmt --all -- --checkgit diff --checkNo speculative preflight comparison was added because
wxc-exec --probedoes not expose a schema version. That would require a separate MXC interface or dry-run design change.Checklist