fix(mxc): preserve JSON arguments in PowerShell 5.1 (NVBug 6843165) - #3893
Merged
Merged
Conversation
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
prekshivyas
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 29, 2026 19:52
shailendra-nv
approved these changes
Sep 29, 2026
shailendra-nv
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the full diff at b6078cd. No blocking findings. Native ARM64 PowerShell 5.1 helper validation passed; Windows CI jobs were skipped. The standalone-test execution-policy dependency is a nonblocking portability suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve
--driver-config-jsonas one exact native argument when the shipped MXC runners execute under Windows PowerShell 5.1. PowerShell's call operator removed the embedded JSON quotes, so the gateway rejected the argument before sandbox creation.Related Issue
Before / after reproduction
Environment: Windows PowerShell 5.1.28000.30169.
The intended argument was:
{"mxc":{"cwd":"C:/Temp","command":["C:/Windows/System32/cmd.exe","/d","/c","exit 0"]}}Before this change, native argument capture received:
{mxc:{cwd:C:/Temp,command:[C:/Windows/System32/cmd.exe,/d,/c,exit 0]}}The local mock gateway then exited 1 with
--driver-config-json must be valid JSONandkey must be a string at line 1 column 2.After this change, the identical JSON remains one byte-for-byte argument, including the space in
exit 0. The same mock gateway path reaches sandbox phaseReadyand launches the harmless command, exit 0.Changes
ProcessStartInfowhile preserving captured stdout, stderr, and exit status.Testing
mise run pre-commitpassesgrpcio-tools 1.78with incompatible MSVC language-standard flags.powershell_native_arguments: 1 passed.demo_examples: 5 passed.openclaw_appcontainer_compat: 6 passed.cargo fmt --all -- --checkgit diff --checkChecklist