fix(mxc): add schema version to test configs (NVBug 6842812) - #3891
Merged
Merged
Conversation
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
prekshivyas
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 29, 2026 19:51
shailendra-nv
approved these changes
Sep 29, 2026
shailendra-nv
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the full diff at 335930f against the current windows base. No blocking findings. Both example headers match gateway schema version 2; the regression test covers missing, incorrectly typed, and incorrect versions. Independent before/after TOML checks passed for both files with all other settings unchanged. Branch checks passed. Windows CI and E2E jobs were skipped; native Windows and real-MXC execution were not independently rerun during review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the shipped Windows MXC OCSF-audit and WebSocket gateway configurations so the current gateway accepts them. Both examples omitted the mandatory gateway schema header and failed before the MXC driver could start.
Related Issue
Before / after reproduction
Before this change, each command exited 1 with
gateway config schema version is required; add [openshell] and version = 2:openshell-gateway.exe --config crates\openshell-driver-mxc\examples\mxc-ocsf-audit.tomlopenshell-gateway.exe --config crates\openshell-driver-mxc\examples\mxc-ws-gateway.tomlAfter this change, the identical commands pass schema validation. With the runners'
OPENSHELL_DRIVERS=mxcenvironment, both configurations reach normal gateway startup/listening.Changes
[openshell]withversion = 2to both shipped configurations.Testing
mise run pre-commitpasses0xC0000005.cargo test -p openshell-driver-mxc --test demo_examples -- --nocapture: 6 passed after rebasing onto the currentwindowstip.cargo fmt --all -- --checkgit diff --checkChecklist