Conversation
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 29, 2026 16:11
6 of 7 tasks
|
🌿 Preview your docs: https://nvidia-preview-pr-3866.docs.buildwithfern.com/openshell |
elezar
force-pushed
the
codex/conformance-after-parity
branch
from
September 30, 2026 06:32
9fee853 to
9994506
Compare
elezar
added this pull request to stack #3939
September 30, 2026 06:32
elezar
force-pushed
the
codex/conformance-after-parity
branch
from
September 30, 2026 10:11
9994506 to
f4da56b
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
codex/conformance-after-parity
branch
from
September 30, 2026 10:19
f4da56b to
d23f53a
Compare
This was referenced Sep 30, 2026
Collaborator
|
Analysis by agent found some cleanup that's worth addressing: Once the CLI crate is removed, these openshell-conformance items have no remaining callers:
Without the registry's consumer, a scenario added to SCENARIOS does not run unless a matching test file is also added. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run driver conformance through the portable Cargo test suites instead of building and distributing the standalone conformance CLI. Remove the obsolete CLI crate now that all supported paths use the library-backed test suites. This PR is stacked on #3864.
Related Issue
Follow-up cleanup for #2792.
Stack
Changes
tests/suites/conformancewith Cargo.crates/openshell-conformance-cliand its workspace lockfile entry.Testing
mise run pre-commitpassescargo test --locked --package openshell-conformancepasses (18 tests)cargo test --locked --manifest-path tests/suites/conformance/Cargo.toml --package openshell-test-conformance-cli --no-runpassesnix-instantiate --parse tests/artifacts.nixpassesChecklist