Skip to content

fix(sdk): validate exec status before yielding exit - #3829

Closed
dipeshbabu wants to merge 1 commit into
NVIDIA:mainfrom
dipeshbabu:fix-typescript-exec-terminal-status/dipeshbabu
Closed

dipeshbabu wants to merge 1 commit into
NVIDIA:mainfrom
dipeshbabu:fix-typescript-exec-terminal-status/dipeshbabu

Conversation

@dipeshbabu

Copy link
Copy Markdown

Summary

Check the final RPC status before exposing a TypeScript exec stream's exit event. Previously a caller that stopped at exit could silently miss a subsequent transport failure, and events received after exit were accepted.

Related Issue

No issue required: localized correction of existing exec stream completion semantics, without changing public types.

Changes

  • Retain the exit code until RPC completion while continuing to stream stdout and stderr immediately.
  • Reject duplicate exit events and output received after exit.
  • Add regressions for a late RPC failure and malformed event ordering.
  • Document when the terminal event is emitted.

Testing

  • mise run pre-commit passes. The full-repository attempt stopped on missing tooling; the commit hook was bypassed. The passing SDK checks below do not establish full repository CI success.
  • All three regression cases fail on the original implementation.
  • mise run --skip-tools sdk:ts:ci passes: protobuf lint/generation, Biome, type checks, build, and 144 tests.
  • Line coverage: 91.73%, above the existing 80% threshold.
  • Full mise run ci passes. Repository-wide validation remains blocked.
  • E2E tests added/updated (not applicable to the client-side terminal-status correction).

Checklist

  • Follows Conventional Commits.
  • Commit is signed off (DCO).
  • Architecture and SDK documentation updated.

Signed-off-by: Dipesh Babu <dipeshmahato@outlook.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown

Thank you for your interest in contributing to OpenShell, @dipeshbabu.

This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer.

To get vouched:

  1. Open a Vouch Request discussion.
  2. Describe what you want to change and why.
  3. Write in your own words — do not have an AI generate the request.
  4. A maintainer will comment /vouch if approved.
  5. Once vouched, open a new PR (preferred) or reopen this one after a few minutes.

See CONTRIBUTING.md for details.

@github-actions github-actions Bot closed this Sep 29, 2026
@github-actions

Copy link
Copy Markdown

Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant