fix(python): enforce lifecycle wait deadlines - #3828
Closed
dipeshbabu wants to merge 1 commit into
Closed
dipeshbabu wants to merge 1 commit into
dipeshbabu wants to merge 1 commit into
Conversation
Signed-off-by: Dipesh Babu <dipeshmahato@outlook.com>
dipeshbabu
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 29, 2026 04:11
|
Thank you for your interest in contributing to OpenShell, @dipeshbabu. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bound Python SDK lifecycle waits by their requested timeout, including lookup RPCs and polling delays. Previously a short wait could spend the full client timeout in GetSandbox and then sleep beyond its remaining budget; wall-clock changes could also alter the duration.
Related Issue
No issue required: localized correction of the existing wait timeout contract, without a public API change.
Changes
Testing
mise run pre-commitpasses. Attempted with--skip-tools; stopped on missingmarkdownlint-cli2. The commit hook was bypassed after this failed attempt; the passing checks below do not establish full CI success.mise run cipasses. Currently blocked by missing tools; full Python suite has the same 19 Windows failures on the unchanged baseline.Checklist