Skip to content

Fix/startup provider readiness - #3819

Open
ebusto wants to merge 2 commits into
NVIDIA:mainfrom
ebusto:fix/startup-provider-readiness
Open

ebusto wants to merge 2 commits into
NVIDIA:mainfrom
ebusto:fix/startup-provider-readiness

Conversation

@ebusto

@ebusto ebusto commented Sep 29, 2026

Copy link
Copy Markdown

Summary

Preserves startup-captured provider readiness so an unchanged settings poll does not unnecessarily reload policy and terminate active connections.

Related Issue

Fixes #3809

Changes

  • Initialize provider readiness from the environment captured during startup.
  • Preserve provider identity and credential expiration metadata.
  • Prevent unchanged settings polls from refetching the provider environment.
  • Add regression coverage verifying policy generations remain active.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (manual comparison on patched and unpatched hosts)

All 132 supervisor tests pass. A first Git clone succeeded on the patched host and reproduced the TLS termination on the unpatched host.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable)

Signed-off-by: Eric Busto <ebusto@nvidia.com>
Signed-off-by: Eric Busto <ebusto@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@johntmyers johntmyers added gator:in-review Gator is reviewing or awaiting PR review feedback test:e2e Requires end-to-end coverage labels Sep 29, 2026
@github-actions

Copy link
Copy Markdown

Label test:e2e applied, but pull-request/3819 does not exist yet. A maintainer needs to comment /ok to test 3f6e9932564597bf99078649bb0f47bcc65dedec to mirror this PR. Once the mirror exists, re-apply the label or re-run Branch E2E Checks from the Actions tab.

@johntmyers johntmyers left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gator-agent

PR Review Status

This concentrated supervisor fix matches the validated issue: it carries the startup provider identity and credential-expiry metadata into the readiness tracker, preventing an unchanged settings poll from invalidating the active policy generation. The complete initial diff has no blocking findings.

Blocking findings:

  • No blocking findings remain

Carried findings:

  • None

Non-blocking suggestions:

  • None
Gator metadata
  • Validation: Project-valid concentrated bug fix linked to validated issue #3809
  • Docs: Not needed because this corrects internal readiness reconciliation without changing the documented user workflow
  • Checks: Vouch, DCO, and existing lightweight checks pass; required current-head branch and Helm jobs are not yet dispatched
  • E2E: test:e2e is required and applied; E2E Label Help is processing the label, but the current-head E2E workflow is not yet confirmed queued
  • Head SHA: 3f6e9932564597bf99078649bb0f47bcc65dedec
  • Base SHA: 1358941b818d4126a7374aaf5216d87fc960e122
  • Merge base SHA: 1358941b818d4126a7374aaf5216d87fc960e122
  • Patch ID: d910cc1b01c108eb7477f7b6c58c0dd8075e3881
  • Gator payload: 9
  • Review mode: initial
  • Previous reviewed SHA: none
  • Review budget exhausted: no
  • Maintainer decision required: no
  • Next state: gator:in-review

@johntmyers

Copy link
Copy Markdown
Collaborator

/ok to test 3f6e993

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gator:in-review Gator is reviewing or awaiting PR review feedback test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

First network request is interrupted by redundant provider environment reconciliation

2 participants