Conversation
Signed-off-by: Eric Busto <ebusto@nvidia.com>
Signed-off-by: Eric Busto <ebusto@nvidia.com>
ebusto
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 29, 2026 01:49
|
Label |
johntmyers
reviewed
Sep 29, 2026
johntmyers
left a comment
Collaborator
There was a problem hiding this comment.
gator-agent
PR Review Status
This concentrated supervisor fix matches the validated issue: it carries the startup provider identity and credential-expiry metadata into the readiness tracker, preventing an unchanged settings poll from invalidating the active policy generation. The complete initial diff has no blocking findings.
Blocking findings:
- No blocking findings remain
Carried findings:
- None
Non-blocking suggestions:
- None
Gator metadata
- Validation: Project-valid concentrated bug fix linked to validated issue #3809
- Docs: Not needed because this corrects internal readiness reconciliation without changing the documented user workflow
- Checks: Vouch, DCO, and existing lightweight checks pass; required current-head branch and Helm jobs are not yet dispatched
- E2E:
test:e2eis required and applied; E2E Label Help is processing the label, but the current-head E2E workflow is not yet confirmed queued - Head SHA:
3f6e9932564597bf99078649bb0f47bcc65dedec - Base SHA:
1358941b818d4126a7374aaf5216d87fc960e122 - Merge base SHA:
1358941b818d4126a7374aaf5216d87fc960e122 - Patch ID:
d910cc1b01c108eb7477f7b6c58c0dd8075e3881 - Gator payload:
9 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:in-review
Collaborator
|
/ok to test 3f6e993 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves startup-captured provider readiness so an unchanged settings poll does not unnecessarily reload policy and terminate active connections.
Related Issue
Fixes #3809
Changes
Testing
mise run pre-commitpassesAll 132 supervisor tests pass. A first Git clone succeeded on the patched host and reproduced the TLS termination on the unpatched host.
Checklist