feat(podman): honor OCI image working directories - #3801
Open
matthewgrossman wants to merge 14 commits into
Open
matthewgrossman wants to merge 14 commits into
matthewgrossman wants to merge 14 commits into
Conversation
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-3801.docs.buildwithfern.com/openshell |
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
|
Label |
Contributor
Author
|
/ok to test 2405282 |
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Contributor
Author
|
/ok to test fc4d8bd |
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
matthewgrossman
marked this pull request as ready for review
September 29, 2026 04:53
matthewgrossman
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 29, 2026 04:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Podman sandboxes now use a custom OCI image
WORKDIRas the persistent workspace and as agent commands' cwd andHOME, bringing Podman into parity with Docker. Empty,/, and/sandboxvalues retain the managed/sandboxfallback. Docker behavior is unchanged.What you can now do
On a Podman gateway host, build an image with a writable custom working directory:
Output from the local Podman gateway run:
Previously Podman used
/sandboxregardless of the image'sWORKDIR.Related Issue
Fixes #2526. Supersedes the Podman approach in #2715. That earlier approach needed complex directory checks to prevent a workload image from overwriting essential supervisor binaries, because the workload and supervisor shared a container. RFC 0012 now runs them in separate containers, so those supervisor-protection checks are no longer necessary. This PR still reuses Docker's existing shared path validation; relaxing it can happen in a follow-up.
Changes
VOLUMEtargets from one immutable inspection./sandboxfallback keeps its previous image-volume behavior.HOME; retain the managed/sandboxsetup for fallback images. Pin and pass the separate supervisor image ID.openshell-core; Docker uses the same helper and label with no intended behavior change. There are no sandbox-runtime diffs.Testing
mise run pre-commitChecklist