Skip to content

fix(conformance): require successful list to certify deletion - #3792

Merged
elezar merged 1 commit into
mainfrom
conformance-deletion-pagination/el
Sep 30, 2026
Merged

elezar merged 1 commit into
mainfrom
conformance-deletion-pagination/el

Conversation

@elezar

@elezar elezar commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Summary

Require a successful, fully parsed openshell sandbox list traversal before the lifecycle conformance scenario certifies sandbox deletion. This isolates the deletion check currently bundled into #3768 and #3769 so command, authentication, gateway, transport, parse, and pagination failures cannot produce a false pass.

Related Issue

No issue required: this is an obvious localized false-positive fix in the conformance harness.

Follow-up: #3944 proposes a first-class, identity-aware CLI deletion wait so callers do not need to implement this list-based workaround.

Changes

  • Replace the nonzero sandbox get deletion signal with a paginated sandbox list search.
  • Capture the original sandbox ID before deletion and search for that identity, so a same-name replacement does not keep the wait alive.
  • Bound each complete pagination observation by a shared deadline and reject repeated page tokens.
  • Treat failed commands, transport errors, malformed JSON, and incomplete pagination as pending observations rather than proof of deletion.

Testing

  • cargo fmt --check -- crates/openshell-conformance/src/scenarios/sandbox_lifecycle.rs
  • cargo test -p openshell-conformance (18 passed)
  • E2E tests added/updated (not applicable; this PR changes the conformance scenario itself)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable; no architecture change)

@elezar elezar added the test:e2e Requires end-to-end coverage label Sep 28, 2026
@github-actions

Copy link
Copy Markdown

Label test:e2e applied for 2045004. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway, sandbox, and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
elezar force-pushed the conformance-deletion-pagination/el branch from 474fb75 to 219bbaf Compare September 30, 2026 08:37
@elezar
elezar enabled auto-merge September 30, 2026 09:14
@elezar
elezar added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit 5acaaba Sep 30, 2026
106 checks passed
@elezar
elezar deleted the conformance-deletion-pagination/el branch September 30, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants