fix(conformance): require successful list to certify deletion - #3792
Merged
Merged
Conversation
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 28, 2026 19:56
|
Label |
9 of 11 tasks
9 tasks
elezar
force-pushed
the
conformance-deletion-pagination/el
branch
from
September 30, 2026 07:37
2045004 to
3c2c0c3
Compare
8 tasks
elezar
force-pushed
the
conformance-deletion-pagination/el
branch
from
September 30, 2026 08:28
3c2c0c3 to
474fb75
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
conformance-deletion-pagination/el
branch
from
September 30, 2026 08:37
474fb75 to
219bbaf
Compare
elezar
enabled auto-merge
September 30, 2026 09:14
alangou
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require a successful, fully parsed
openshell sandbox listtraversal before the lifecycle conformance scenario certifies sandbox deletion. This isolates the deletion check currently bundled into #3768 and #3769 so command, authentication, gateway, transport, parse, and pagination failures cannot produce a false pass.Related Issue
No issue required: this is an obvious localized false-positive fix in the conformance harness.
Follow-up: #3944 proposes a first-class, identity-aware CLI deletion wait so callers do not need to implement this list-based workaround.
Changes
sandbox getdeletion signal with a paginatedsandbox listsearch.Testing
cargo fmt --check -- crates/openshell-conformance/src/scenarios/sandbox_lifecycle.rscargo test -p openshell-conformance(18 passed)Checklist