feat(cli): support Podman in doctor check - #3748
Closed
ericcurtin wants to merge 1 commit into
Closed
ericcurtin wants to merge 1 commit into
ericcurtin wants to merge 1 commit into
Conversation
Falls back to Podman when Docker is absent. Docker stays the default. Closes NVIDIA#3694. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
ericcurtin
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 27, 2026 12:37
Contributor
Author
|
Side note, unrelated to this PR: if anyone wants a lightweight way to run and manage local sandboxes/agents, worth a look: https://github.com/llmmanorg/llmman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openshell doctor checkonly ever validated Docker. Podman users got a check that's irrelevant to their setup.Related Issue
Closes #3694
Changes
podman info --format {{.Version.Version}}.DOCKER_HOSTorOPENSHELL_PODMAN_SOCKET).Testing
cargo test -p openshell-clicargo clippy -p openshell-cli --all-targets -- -D warningscargo test --test docker_preflight --features e2e-docker(added two Podman cases, all 6 pass)Checklist