Skip to content

feat(cli): detach sandbox sessions with Ctrl-D - #3744

Merged
drew merged 1 commit into
mainfrom
codex/3743-ctrl-d-detach
Sep 28, 2026
Merged

drew merged 1 commit into
mainfrom
codex/3743-ctrl-d-detach

Conversation

@drew

@drew drew commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

Allow Ctrl-D to detach an attachment to a sandbox's canonical main process, leaving the process and stdin available for reconnection. Ctrl-P followed by Ctrl-Q continues to work.

Related Issue

Closes #3743

Changes

  • Recognize Ctrl-D in the supervisor's canonical main-session input filter and close only the attachment.
  • Cover input-owner and read-only viewer detachment, lease handling, and the existing Ctrl-P/Ctrl-Q sequence.
  • Update CLI help, recovery guidance, published sandbox docs, architecture notes, and the public CLI skill.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated: cargo test -p openshell-supervisor-process --lib (80 passed)
  • E2E tests added/updated (not applicable to this scoped input handling change)

mise run test stopped on two supervisor-network WebSocket tests outside the changed code: plaintext_websocket_preflight_denial_does_not_connect_upstream and plaintext_websocket_middleware_inspects_compressed_ws_messages. The first received policy_denied where its assertion expected middleware_denied.

mise run ci did not pass: Go gateway-list tests observed the host's configured default system gateway where they expected empty or test-only gateway lists. These failures are outside the changed files.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@github-actions

Copy link
Copy Markdown

@johnnygreco johnnygreco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks @drew!

@drew
drew merged commit 36b0386 into main Sep 28, 2026
74 checks passed
@drew
drew deleted the codex/3743-ctrl-d-detach branch September 28, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: detach canonical sandbox sessions with Ctrl-D

2 participants