feat(cli): detach sandbox sessions with Ctrl-D - #3744
Merged
Merged
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 27, 2026 00:20
|
🌿 Preview your docs: https://nvidia-preview-pr-3744.docs.buildwithfern.com/openshell |
johnnygreco
approved these changes
Sep 28, 2026
johnnygreco
left a comment
Collaborator
There was a problem hiding this comment.
Sweet, thanks @drew!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow Ctrl-D to detach an attachment to a sandbox's canonical main process, leaving the process and stdin available for reconnection. Ctrl-P followed by Ctrl-Q continues to work.
Related Issue
Closes #3743
Changes
Testing
mise run pre-commitpassescargo test -p openshell-supervisor-process --lib(80 passed)mise run teststopped on two supervisor-network WebSocket tests outside the changed code:plaintext_websocket_preflight_denial_does_not_connect_upstreamandplaintext_websocket_middleware_inspects_compressed_ws_messages. The first receivedpolicy_deniedwhere its assertion expectedmiddleware_denied.mise run cidid not pass: Go gateway-list tests observed the host's configureddefaultsystem gateway where they expected empty or test-only gateway lists. These failures are outside the changed files.Checklist