Conversation
engelmi
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 16, 2026 12:38
2 tasks done
engelmi
force-pushed
the
add-delete-prune-option
branch
from
September 17, 2026 06:34
5e9dcbf to
e0c79cd
Compare
Collaborator
|
I think we just want to prune sandboxes in confirmed terminal states. That is |
engelmi
force-pushed
the
add-delete-prune-option
branch
from
September 18, 2026 06:41
e0c79cd to
d0ef037
Compare
Author
Agreed. I pushed the changes. PTAL @sjenning |
Collaborator
|
/ok to test d0ef037 |
engelmi
force-pushed
the
add-delete-prune-option
branch
2 times, most recently
from
September 22, 2026 07:33
9362ae8 to
c2ed632
Compare
Author
|
@sjenning I had to rebase. Could you trigger the CI again? |
engelmi
force-pushed
the
add-delete-prune-option
branch
from
September 29, 2026 07:15
c2ed632 to
a2579c7
Compare
ericcurtin
approved these changes
Sep 29, 2026
ericcurtin
left a comment
ericcurtin
left a comment
Contributor
There was a problem hiding this comment.
FWIW (not that it's worth much), LGTM
Add a --prune flag to `openshell sandbox delete` that deletes only inactive sandboxes. This allows users to clean up terminated, stopped, or errored sandboxes while preserving active and provisioning ones. The prune filter targets sandboxes in these phases: - Unspecified - Unknown - Error - Deleting - Stopped - Completed Active sandboxes (Ready, Provisioning, Starting) are preserved. The flag conflicts with both --all and named sandbox arguments, ensuring clear deletion intent. Fixes: NVIDIA#2594 Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
force-pushed
the
add-delete-prune-option
branch
from
September 30, 2026 15:05
a2579c7 to
9f33ea4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a --prune flag to
openshell sandbox deletethat deletes only inactive sandboxes. This allows users to clean up terminated, stopped, or errored sandboxes while preserving active and provisioning ones.The prune filter targets sandboxes in these (inactive) phases:
Sandboxes in unconfirmed or non-terminal states are preserved.
The flag conflicts with both --all and named sandbox arguments, ensuring clear deletion intent.
Related Issue
Fixes: #2594
Changes
Testing
mise run pre-commitpasses- [ ] E2E tests added/updated (if applicable)(not applicable)Checklist
- [] Architecture docs updated (if applicable)(not applicable)