Skip to content

refactor(rpm): Moved openshell-gateway.service from RPM to dedicated file - #2592

Open
engelmi wants to merge 1 commit into
NVIDIA:mainfrom
engelmi:rpm-extract-openshell-gateway
Open

engelmi wants to merge 1 commit into
NVIDIA:mainfrom
engelmi:rpm-extract-openshell-gateway

Conversation

@engelmi

@engelmi engelmi commented Aug 3, 2026 •

Copy link
Copy Markdown

Summary

The inline heredocs in the openshell.spec is hard to lint, diff, and edit. Therefore, moving it into a dedicated file so it gets proper syntax highlighting, can be validated by systemd-analyze verify and is easier to review in isolation.
This also aligns with the .deb packaging.

Related Issue

No issue required: Small, mechanical change

Changes

Moves the RPM packaged openshell-gateway.service from spec file to deploy/rpm/openshell-gateway.service

Testing

  • mise run pre-commit passes
  • Unit tests added/updated (not needed)
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@copy-pr-bot

copy-pr-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@engelmi

engelmi commented Aug 3, 2026

Copy link
Copy Markdown
Author

I have read the DCO document and I hereby sign the DCO.

mrunalp
mrunalp previously approved these changes Aug 3, 2026
@engelmi
engelmi force-pushed the rpm-extract-openshell-gateway branch from 1706828 to e23bbe5 Compare August 4, 2026 10:33
@engelmi

engelmi commented Aug 4, 2026

Copy link
Copy Markdown
Author

Rebased the branch with the latest changes on main

@engelmi
engelmi force-pushed the rpm-extract-openshell-gateway branch from e23bbe5 to a075731 Compare August 5, 2026 10:05
@engelmi

engelmi commented Aug 5, 2026

Copy link
Copy Markdown
Author

/ok to test

@engelmi

engelmi commented Aug 5, 2026

Copy link
Copy Markdown
Author

@mrunalp Could you trigger the pending (required) CI runs? It seems I lack the necessary privileges.

@engelmi
engelmi force-pushed the rpm-extract-openshell-gateway branch from a075731 to d572852 Compare August 6, 2026 10:28
@mrunalp

mrunalp commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

/ok to test d572852

@engelmi
engelmi force-pushed the rpm-extract-openshell-gateway branch 4 times, most recently from 27914c9 to 5c1bf37 Compare August 13, 2026 11:23
@engelmi

engelmi commented Aug 13, 2026

Copy link
Copy Markdown
Author

Anything blocking this from being merged? Its just a small change and approved.

@engelmi

engelmi commented Aug 19, 2026

Copy link
Copy Markdown
Author

@mrunalp Could this be merged?

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

This pull request has had no activity for 14 days and is now marked stale. It may be closed in 7 days if there is no further activity.

@github-actions github-actions Bot added the state:stale Inactive item at risk of automatic closure. label Sep 2, 2026
@engelmi
engelmi force-pushed the rpm-extract-openshell-gateway branch from 5c1bf37 to 02cae18 Compare September 11, 2026 14:55
@engelmi
engelmi requested a review from sjenning as a code owner September 11, 2026 14:55
@github-actions github-actions Bot removed the state:stale Inactive item at risk of automatic closure. label Sep 12, 2026
@politerealism

Copy link
Copy Markdown
Contributor

@mrunalp this one's been sitting since early August with an approved CI run and a dismissed review (looks like just from a later commit, not a rejection). it's a small, mechanical move with no functional change, and the stale-bot is about to close it. Could you take another look or point to who can merge it?

@engelmi
engelmi force-pushed the rpm-extract-openshell-gateway branch 2 times, most recently from 3602e47 to b67b4e9 Compare September 22, 2026 08:21
@engelmi

engelmi commented Sep 22, 2026

Copy link
Copy Markdown
Author

@mrunalp @derekwaynecarr I had to rebase. Could you trigger the CI again?

@engelmi
engelmi force-pushed the rpm-extract-openshell-gateway branch from b67b4e9 to 07ee77b Compare September 29, 2026 07:15
…file

The inline heredocs in the `openshell.spec` is hard to lint, diff, and edit.
Therefore, moving it into a dedicated file so it gets proper syntax
highlighting, can be validated by `systemd-analyze verify` and is easier to
review in isolation. This also aligns with the .deb packaging.

Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi
engelmi force-pushed the rpm-extract-openshell-gateway branch from 07ee77b to bde87fe Compare September 30, 2026 15:05

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants