Conversation
|
All contributors have signed the DCO ✍️ ✅ |
|
I have read the DCO document and I hereby sign the DCO. |
1706828 to
e23bbe5
Compare
|
Rebased the branch with the latest changes on main |
e23bbe5 to
a075731
Compare
|
/ok to test |
|
@mrunalp Could you trigger the pending (required) CI runs? It seems I lack the necessary privileges. |
a075731 to
d572852
Compare
|
/ok to test d572852 |
27914c9 to
5c1bf37
Compare
|
Anything blocking this from being merged? Its just a small change and approved. |
|
@mrunalp Could this be merged? |
|
This pull request has had no activity for 14 days and is now marked stale. It may be closed in 7 days if there is no further activity. |
5c1bf37 to
02cae18
Compare
|
@mrunalp this one's been sitting since early August with an approved CI run and a dismissed review (looks like just from a later commit, not a rejection). it's a small, mechanical move with no functional change, and the stale-bot is about to close it. Could you take another look or point to who can merge it? |
3602e47 to
b67b4e9
Compare
|
@mrunalp @derekwaynecarr I had to rebase. Could you trigger the CI again? |
b67b4e9 to
07ee77b
Compare
…file The inline heredocs in the `openshell.spec` is hard to lint, diff, and edit. Therefore, moving it into a dedicated file so it gets proper syntax highlighting, can be validated by `systemd-analyze verify` and is easier to review in isolation. This also aligns with the .deb packaging. Signed-off-by: Michael Engel <mengel@redhat.com>
07ee77b to
bde87fe
Compare
Summary
The inline heredocs in the
openshell.specis hard to lint, diff, and edit. Therefore, moving it into a dedicated file so it gets proper syntax highlighting, can be validated bysystemd-analyze verifyand is easier to review in isolation.This also aligns with the .deb packaging.
Related Issue
No issue required: Small, mechanical change
Changes
Moves the RPM packaged
openshell-gateway.servicefrom spec file todeploy/rpm/openshell-gateway.serviceTesting
mise run pre-commitpassesUnit tests added/updated(not needed)E2E tests added/updated (if applicable)Checklist
Architecture docs updated (if applicable)