ci(helm): add helm lint workflow and reorganize chart values under ci/#1223
Open
TaylorMutch wants to merge 2 commits intomainfrom
Open
ci(helm): add helm lint workflow and reorganize chart values under ci/#1223TaylorMutch wants to merge 2 commits intomainfrom
TaylorMutch wants to merge 2 commits intomainfrom
Conversation
TaylorMutch
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
Collaborator
Author
|
/ok to test ddca7ab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a CI job that lints the OpenShell Helm chart against multiple configuration variants, and reorganizes the dev/CI values overlays under
deploy/helm/openshell/ci/so they are clearly separated from the chart's defaultvalues.yaml.Related Issue
N/A
Changes
.github/workflows/helm-lint.ymlworkflow runsmise run helm:linton PRs touchingdeploy/helm/**.values-skaffold.yaml,values-cert-manager.yaml,values-gateway.yaml, andvalues-keycloak.yamlintodeploy/helm/openshell/ci/.ci/values-tls-disabled.yamlfor the reverse-proxy/edge-termination lint variant.helm:linttask to lint defaults plus everyci/values-*.yamloverlay.skaffold.yaml,.helmignore, and thehelm-dev-environmentskill to reference the newci/paths.Testing
mise run pre-commitpassesmise run helm:lintpasses locally across all variantsChecklist
helm-dev-environmentSKILL.md)