fix(installer): install release formula from Homebrew tap#1222
Merged
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
TaylorMutch
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the macOS
install-dev.shHomebrew path by staging the downloaded release formula in thenvidia/openshelltap before installing it. This avoids current Homebrew rejecting tempopenshell.rbpaths while preserving the release formula install flow for either the default dev release or a tagged release selected withOPENSHELL_VERSION.The change also makes the formula postinstall idempotent so reinstalls can refresh the Hypervisor entitlement plist and re-run codesign.
Related Issue
None.
Changes
nvidia/openshellHomebrew tap before install or reinstall.entitlements.writetoentitlements.atomic_writebefore staging.atomic_writefor the entitlement plist going forward.Testing
mise run pre-commitpassessh -n install-dev.shshellcheck install-dev.shuv run pytest python/openshell/release_formula_test.pygit diff --checksh ./install-dev.shverified Homebrew reinstall fromnvidia/openshell/openshell, postinstall codesign, and qualified service restartChecklist