refactor: generalize container build tooling for Docker and Podman compatibility#1220
Open
maxamillion wants to merge 1 commit intoNVIDIA:mainfrom
Open
refactor: generalize container build tooling for Docker and Podman compatibility#1220maxamillion wants to merge 1 commit intoNVIDIA:mainfrom
maxamillion wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
…mpatibility Rename Docker-branded env vars, scripts, and mise tasks to generic container terminology while preserving full backwards compatibility. - Add ce_resolve_containerfile() helper to container-engine.sh that auto-detects Containerfile.X or Dockerfile.X (Containerfile preferred) - Rename build scripts from docker-* to container-* (4 files) - Add CONTAINER_* env var equivalents with DOCKER_* fallbacks (9 vars) - Create tasks/container.toml with canonical build:container:* task names - Convert tasks/docker.toml to pure alias file for backwards compat - Update all cross-references in shell scripts, TOML task files, CI workflow, architecture docs, and agent files - Fix pre-existing bug: remove exec keyword from container-build-ci.sh (exec does not work with bash functions) Closes NVIDIA#968 Signed-off-by: Adam Miller <admiller@redhat.com>
maxamillion
requested review from
a team,
derekwaynecarr and
mrunalp
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename Docker-branded env vars, scripts, and mise tasks to generic container terminology while preserving full backwards compatibility. This implements the plan from issue #968.
Related Issue
Closes #968
Changes
ce_resolve_containerfile()helper tocontainer-engine.shthat auto-detectsContainerfile.XorDockerfile.X(Containerfile preferred, matching Podman convention)docker-*tocontainer-*(4 files:container-build-image.sh,container-build-ci.sh,container-publish-multiarch.sh,container-cleanup.sh)CONTAINER_*env var equivalents withDOCKER_*fallbacks for backwards compatibility (9 variables across 3 scripts)tasks/container.tomlwith canonicalbuild:container:*task names (8 tasks)tasks/docker.tomlto pure backwards-compat alias file (build:docker:*→build:container:*viadepends)cluster-deploy-fast.sh,cluster-push-component.sh,cluster-bootstrap.sh,remote-deploy.sh,gateway-docker.sh,gateway.sh), 4 TOML task files (ci.toml,cluster.toml,test.toml,vm.toml), CI workflow (docker-build.yml), architecture docs (build-containers.md), and agent files (AGENTS.md,doctor_llm_prompt.md,e2e-podman.sh)cluster-deploy-fast.shpattern matches and fingerprint inputs to recognize bothContainerfile.imagesandDockerfile.imagesexeckeyword fromcontainer-build-ci.sh(execdoes not work with bash functions fromcontainer-engine.sh)Testing
mise run pre-commitpasses (lint, format, license headers)Checklist
build-containers.md)