feat(server): expose grpc.health and reflection on the gateway multiplex#1181
Open
ddurst-nvidia wants to merge 2 commits intoNVIDIA:mainfrom
Open
feat(server): expose grpc.health and reflection on the gateway multiplex#1181ddurst-nvidia wants to merge 2 commits intoNVIDIA:mainfrom
ddurst-nvidia wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Wire grpc.health.v1.Health (Check; Watch UNIMPLEMENTED) and grpc.reflection.v1.ServerReflection next to OpenShell and Inference in multiplex routing. - Emit and embed a protobuf FileDescriptorSet in openshell-core for reflection. - Deprecate openshell.v1.OpenShell/Health in proto; keep legacy RPC aligned with process liveness and silence deprecation warnings where callers still use it (CLI status, TUI, VM health check, WS tunnel integration tests). - Tighten OIDC unauthenticated routing/docs for standard health vs legacy OpenShell/Health. - Extend server multiplex integration coverage (plaintext/TLS), auth endpoint plaintext stack, edge-tunnel TLS tests, and CLI mTLS integration to exercise the new health surface; add shared test inference stub. Signed-off-by: ddurst <267424412+ddurst-nvidia@users.noreply.github.com>
…tegration tests Signed-off-by: ddurst <267424412+ddurst-nvidia@users.noreply.github.com>
ddurst-nvidia
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire the standard
grpc.health.v1.Healthandgrpc.reflection.v1.ServerReflectionservices next to OpenShell and Inference on the gateway multiplex, so generic gRPC tooling (grpcurl, health probes, service discovery) works against the gateway without OpenShell-specific knowledge. The legacyopenshell.v1.OpenShell/HealthRPC is deprecated but kept aligned with process liveness for existing callers.Related Issue
N/A
Changes
grpc.health.v1.Health(CheckreturningSERVING;WatchUNIMPLEMENTED) andgrpc.reflection.v1.ServerReflectionto the gateway multiplex routing alongside OpenShell and Inference.FileDescriptorSetinopenshell-coreso reflection can serve OpenShell service descriptors.openshell.v1.OpenShell/Healthas deprecated in the proto, keeping its current process-liveness semantics; silence deprecation warnings at remaining call sites (CLIstatus, TUI, VM health check, WS tunnel integration test).grpc.health.v1.Healthfrom the legacy OpenShell health RPC.Testing
mise run pre-commitpassesChecklist