Skip to content

feat(gpu): introduce GPU request spec#1156

Draft
elezar wants to merge 4 commits intomainfrom
feat/gpu-request-spec
Draft

feat(gpu): introduce GPU request spec#1156
elezar wants to merge 4 commits intomainfrom
feat/gpu-request-spec

Conversation

@elezar
Copy link
Copy Markdown
Member

@elezar elezar commented May 4, 2026

Summary

Replace the sandbox GPU boolean/string fields with an optional GPU request spec and unify CDI GPU device ID handling across Docker and Podman.

Related Issue

None

Changes

  • Centralized per-driver GPU request validation before changing the spec shape.
  • Simplified VM GPU request derivation so one optional value drives GPU assignment.
  • Added optional GpuRequestSpec with repeated device_id fields in public and driver protos.
  • Shared CDI GPU device ID mapping through openshell-core and wired Docker/Podman through it.
  • Updated Kubernetes and VM GPU request validation, CLI/server mapping, tests, and architecture docs.
  • Added CDI GPU e2e coverage for default GPU requests and specific device requests via nvidia.com/gpu=0, with Docker and Podman GPU task wiring.

Testing

  • mise run pre-commit passes
  • cargo test --manifest-path e2e/rust/Cargo.toml --features e2e --test cdi_gpu --no-run
  • cargo clippy --manifest-path e2e/rust/Cargo.toml --all-targets -- -D warnings
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

elezar added 3 commits May 4, 2026 21:56
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 4, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant