fix(e2e): finish plan-free risk signal cleanup - #8561
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (4)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughManual E2E dispatch documentation now uses variables for workflow settings and describes expanded trusted validation. Risk-signal handling removes plan-hash metadata, validates Git SHAs, and updates tests and evidence documentation. ChangesE2E risk-signal alignment
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Contributor
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit bbb590e in the TypeScript / code-coverage/cliThe overall coverage in commit bbb590e in the Show a code coverage summary of the most impacted files.
Updated |
Contributor
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
1 terminology difference from the second opinionAdvisory only. These are normalized differences from the primary terminology receipt.
6 additional E2E selections from the second opinionAdvisory only. The primary lane did not select these E2E jobs or targets.
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. 3 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite against this exact revision. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/e2e.yaml:
- Around line 285-287: The manual PR E2E authentication must bind inference_mode
to the trusted plan. Update the plan_identity hash inputs and the corresponding
dispatch/planner command flow to include the selected inference_mode, ensuring
non-mock modes cannot be changed after authorization; alternatively, reject
non-mock inference_mode values before checkout.
In `@tools/e2e/operations-workflow-boundary.mts`:
- Around line 310-312: Update the boundary assertions in the workflow validation
to require expected_plan_hash to equal the SHA-256 digest of plan_identity,
matching the derivation in the e2e workflow. Extend the regression so it alters
the hash input or derivation itself, rather than only changing the comparison
operator, and ensure that altered derivation fails validation.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: ec0b2274-1b48-4003-861b-872434e5b3a5
📒 Files selected for processing (7)
.agents/skills/nemoclaw-maintainer-e2e/SKILL.md.github/workflows/e2e.yamltest/e2e/docs/README.mdtest/e2e/support/e2e-operations-workflow-boundary.test.tstest/maintainer-e2e-skill.test.tstools/e2e/cli-artifact-workflow-boundary.mtstools/e2e/operations-workflow-boundary.mts
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
jyaunches
changed the title
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
cv
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The August 6 E2E simplification removed the PR risk-plan controller and its
plan_hashworkflow input, but manual PR risk-signal generation still requiredNEMOCLAW_E2E_PLAN_HASH. Manual PR Vitest runs therefore stopped before live tests. This change finishes that cleanup by removing the stale field while preserving exact revision and correlation evidence.Changes
planHashfrom the risk-signal schema, environment validation, reporter merge identity, and emitted evidence.maininto the branch.Type of Change
Quality Gates
21ab99f16verified that direct pre-checkout authorization remains unchanged and risk-signal evidence retains candidate SHA, correlation, job, shard, and result identity.Documentation Writer Review
docs-updated.agents/skills/nemoclaw-maintainer-e2e/SKILL.md;test/e2e/docs/README.md. The independent exact-head review found no blockers or suggestions.DGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpm exec -- vitest run --project e2e-support: 2,136 passed and 17 skipped across 200 files;npm run typecheck:clipassed.npm run docsbuilds without warnings (doc changes only)Signed-off-by: Julie Yaunches jyaunches@nvidia.com
Summary by CodeRabbit
Bug Fixes
Documentation