test(inference): cover receipt authority rejection - #8435
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
📝 WalkthroughWalkthroughAdded regression tests for malformed receipt-writer authority and mismatched model generation. The tests verify rejection before Docker interaction, receipt publication, or journal mutation. ChangesReceipt validation tests
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 8d1b404 in the TypeScript / code-coverage/cliThe overall coverage in commit 8d1b404 in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
1 additional E2E selection from the second opinionAdvisory only. The primary lane did not select these E2E jobs or targets.
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. 2 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite against this exact revision. Recommended E2E: 1 optional E2E recommendation
This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Summary
Adds regression coverage for two receipt-authority rejection paths introduced by #8422.
The tests confirm that invalid authority data stops processing before engine, journal, or receipt-publication mutation.
Production behavior does not change.
Changes
startedphase after the receipt mismatch.Type of Change
Quality Gates
4d70daff0b638a881ef105672e958307791d391dagainst base SHA2f297843b8fddad80b046eaf34f2987bdd922711. The test-only diff verifies that malformed receipt-writer authority and a receipt whose model generation differs from durable create authority are rejected before engine, journal, or receipt-publication mutation. It changes no production code, credential handling, policy, dependency, or runtime configuration.Documentation Writer Review
no-docs-needed4d70daff0b638a881ef105672e958307791d391dagainst base SHA2f297843b8fddad80b046eaf34f2987bdd922711covered the complete effective diff. The two additions are negative source tests for existing receipt-writer and create-journal authority controls. They change no user-facing command, configuration, API, workflow, default, error, or supported behavior. Both test titles followWRITING.mdand place issue references in final suffixes.DGX Station Hardware Evidence
scripts/prepare-dgx-station-host.shdoes not change.Verification
Signed-off-by:line and every commit appears asVerifiedin GitHub — GitHub reports all four commits asVerified.pre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailable —commitlint, the generated-artifact age check, CLI TypeScript checking, and package-version synchronization passed through normal hooks.4d70daff0. No standalone local test suite ran.npm run docsbuilds without warnings (doc changes only) — not applicable; no documentation file changed.Sensitive-Path Security Review
Independent review found no security finding for PR commit
4d70daff0b638a881ef105672e958307791d391dagainst base SHA2f297843b8fddad80b046eaf34f2987bdd922711.Required checks and independent maintainer approval remain separate merge requirements.
GitHub Actions
GitHub Actions is authoritative for PR commit
4d70daff0b638a881ef105672e958307791d391dagainst base SHA2f297843b8fddad80b046eaf34f2987bdd922711.Required checks started after the branch update.
No check waiver is recorded.
Signed-off-by: Carlos Villela cvillela@nvidia.com