Skip to content

test(inference): allow YAML-only Spark activation - #8273

Merged
ericksoa merged 2 commits into
mainfrom
test/llamacpp-yaml-only-activation-8260
Aug 5, 2026
Merged

test(inference): allow YAML-only Spark activation#8273
ericksoa merged 2 commits into
mainfrom
test/llamacpp-yaml-only-activation-8260

Conversation

@ericksoa

@ericksoa ericksoa commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Prepare the protected llama.cpp DGX Spark qualification tests for a later YAML-only activation. The tests now derive dormant and enabled fixtures from parsed YAML instead of assuming that the repository manifest remains dormant.

Related Issue

Part of #8260

Changes

  • Construct dormant and enabled qualification fixtures by changing parsed YAML fields. The protected qualification exporter consumes these fixtures, and its existing tests cover both states.
  • Validate the publication and qualification state declared by the repository manifest without adding a TypeScript default.
  • Remove the dormant-state wording from the workflow-boundary test title because the trusted workflow supports both declared states.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification: This PR changes deterministic test fixtures only. It does not change production source, repository YAML, workflows, commands, defaults, errors, or supported product behavior.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

  • Documentation writer subagent reviewed the completed changes
  • Result: no-docs-needed
  • Evidence: Reviewed the full three-file test diff at e0e0eaa5b. The tests remove dormant-state assumptions and construct qualification fixtures through YAML without changing production source, repository-owned YAML, CLI behavior, workflow behavior, defaults, errors, or supported product behavior. No documentation changes are required. Focused tests passed (59/59); Biome and the test-conditionals scan passed.
  • Agent: Codex Desktop

DGX Station Hardware Evidence

  • Tested on DGX Station
  • Tested commit: Not applicable; this PR does not change scripts/prepare-dgx-station-host.sh.
  • Station profile/scenario: Not applicable.
  • Result: Not applicable.
  • Supporting evidence: Not applicable.

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — npx vitest run test/llama-cpp-image.test.ts test/llama-cpp-dgx-spark-qualification-plan.test.ts test/e2e/support/llama-cpp-dgx-spark-qualification-workflow.test.ts --project integration --project e2e-support passed 59 tests.
  • Applicable broad gate passed — Not applicable; this PR changes deterministic fixtures in three existing tests and does not change the test harness.
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Aaron Erickson aerickson@nvidia.com

Summary by CodeRabbit

  • Tests
    • Improved qualification test coverage by configuring YAML fixtures through structured data.
    • Updated publication checks to validate enabled and disabled qualification states from the manifest.
    • Preserved validation coverage for invalid qualification configurations.
    • Clarified trusted qualification workflow test naming without changing behavior.

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 95e1560f-14c2-438d-a01f-d76d65594b5d

📥 Commits

Reviewing files that changed from the base of the PR and between 88c11fc and e0e0eaa.

📒 Files selected for processing (1)
  • test/llama-cpp-image.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/llama-cpp-image.test.ts

📝 Walkthrough

Walkthrough

The tests now parse and serialize YAML qualification fixtures instead of using string substitutions. Assertions derive expected qualification state from manifests, and the trusted workflow-boundary test description removes the “dormant” qualifier.

Changes

Qualification test updates

Layer / File(s) Summary
Structured qualification fixture configuration
test/llama-cpp-dgx-spark-qualification-plan.test.ts, test/llama-cpp-image.test.ts
Tests parse YAML manifests and update qualification, publication, runner, environment, and model path fields through structured objects.
Qualification assertions and workflow naming
test/llama-cpp-image.test.ts, test/e2e/support/llama-cpp-dgx-spark-qualification-workflow.test.ts
Assertions derive expected states from manifests. Invalid fixtures use the configurator, and the workflow-boundary test description is renamed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested labels: area: inference, platform: dgx-spark

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: enabling YAML-only Spark activation in inference tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/llamacpp-yaml-only-activation-8260

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit e0e0eaa in the test/llamacpp-yaml-o... branch remains at 96%, unchanged from commit ed13d71 in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit e0e0eaa in the test/llamacpp-yaml-o... branch remains at 81%, unchanged from commit 4e49bf1 in the main branch.

Show a code coverage summary of the most impacted files.
File main 4e49bf1 test/llamacpp-yaml-o... e0e0eaa +/-
src/lib/inferen...ompatibility.ts 94% 94% 0%
src/lib/sandbox...rce-identity.ts 87% 87% 0%
src/lib/tunnel/services.ts 76% 76% 0%
src/lib/credentials/store.ts 55% 56% +1%

Updated August 05, 2026 00:54 UTC

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

  • GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Failed after a partial review · low confidence · 0 blockers · 0 warnings · 0 suggestions

Second-opinion terminology and E2E selections are advisory. They do not change the primary assessment or E2E / PR Gate.

1 semantic terminology decision

Terminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.

  • established — trusted qualification at test/e2e/support/llama-cpp-dgx-spark-qualification-workflow.test.ts:36: Keep “trusted qualification”; removing “dormant” preserves the established meaning because the lane supports both declared states.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: None

1 optional E2E recommendation
  • llama-cpp-dgx-spark-qualification

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

@ericksoa
ericksoa merged commit 2b18817 into main Aug 5, 2026
102 of 106 checks passed
@ericksoa
ericksoa deleted the test/llamacpp-yaml-only-activation-8260 branch August 5, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant