test(inference): allow YAML-only Spark activation - #8273
Conversation
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe tests now parse and serialize YAML qualification fixtures instead of using string substitutions. Assertions derive expected qualification state from manifests, and the trusted workflow-boundary test description removes the “dormant” qualifier. ChangesQualification test updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit e0e0eaa in the TypeScript / code-coverage/cliThe overall coverage in commit e0e0eaa in the Show a code coverage summary of the most impacted files.
Updated |
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Second-opinion terminology and E2E selections are advisory. They do not change the primary assessment or E2E / PR Gate. 1 semantic terminology decisionTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: None 1 optional E2E recommendation
This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Summary
Prepare the protected llama.cpp DGX Spark qualification tests for a later YAML-only activation. The tests now derive dormant and enabled fixtures from parsed YAML instead of assuming that the repository manifest remains dormant.
Related Issue
Part of #8260
Changes
Type of Change
Quality Gates
Documentation Writer Review
no-docs-needede0e0eaa5b. The tests remove dormant-state assumptions and construct qualification fixtures through YAML without changing production source, repository-owned YAML, CLI behavior, workflow behavior, defaults, errors, or supported product behavior. No documentation changes are required. Focused tests passed (59/59); Biome and the test-conditionals scan passed.DGX Station Hardware Evidence
scripts/prepare-dgx-station-host.sh.Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpx vitest run test/llama-cpp-image.test.ts test/llama-cpp-dgx-spark-qualification-plan.test.ts test/e2e/support/llama-cpp-dgx-spark-qualification-workflow.test.ts --project integration --project e2e-supportpassed 59 tests.npm run docsbuilds without warnings (doc changes only)Signed-off-by: Aaron Erickson aerickson@nvidia.com
Summary by CodeRabbit