test(images): align aiohttp capability union pin - #8233
Conversation
Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe test updates two Hermes ChangesHermes package expectations
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 37cb0a7 in the TypeScript / code-coverage/cliThe overall coverage in commit 37cb0a7 in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — InformationalAdvisor assessment: Informational / low confidence Model lanes
Second-opinion terminology and E2E selections are advisory. They do not change the primary assessment or E2E / PR Gate. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: None This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
|
Exact-head review status for
The PR is now ready for CodeRabbit and human review. The repeated Nemotron failure remains visible and is not self-waived; a maintainer can accept that non-success or request a later workflow retry. |
|
redundant |
Summary
Aligns the managed-image capability union test with the authoritative Hermes Teams dependency pin introduced on
main. Before this change, the test still expectedaiohttp==3.14.1; it now expects the shippedaiohttp==3.14.3pin and stops failing unrelated pull requests.Changes
aiohttp==3.14.1toaiohttp==3.14.3.nemoclaw-blueprint/model-specific-setup/hermes/teams.json.Type of Change
Quality Gates
aiohttp==3.14.3.Documentation Writer Review
no-docs-neededtest/managed-image-capability-union.test.ts, the authoritative Hermes Teams dependency manifest, and existing dependency documentation; no documentation files require changes.Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpx vitest run --project integration test/managed-image-capability-union.test.ts(5 passed)npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — not applicable to two stale dependency-version expectationsnpm run docsbuilds without warnings (doc changes only)Signed-off-by: Charan Jagwani cjagwani@nvidia.com
Summary by CodeRabbit
Tests
Chores