ci(e2e): omit Jetson from automatic PR plans - #8230
Conversation
Signed-off-by: San Dang <sdang@nvidia.com>
📝 WalkthroughWalkthroughThe PR-gate E2E planner and PR Review Advisor now exclude ChangesJetson PR-gate selection
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit b404713 in the TypeScript / code-coverage/cliThe overall coverage in commit b404713 in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
4 terminology differences from the second opinionAdvisory only. These are normalized differences from the primary terminology receipt.
Second-opinion terminology and E2E selections are advisory. They do not change the primary assessment or E2E / PR Gate. 3 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Signed-off-by: San Dang <sdang@nvidia.com>
cjagwani
left a comment
There was a problem hiding this comment.
Approved for the exact code revision b404713c55e5fe5a7e3539b9fd51a67f90645af6, subject to required CI completing successfully.
Nine-category security review: PASS with no findings.
- Secrets/credentials: no credential handling changes.
- Input validation: the omission is a fixed trusted job ID, not PR-controlled input.
- Authentication/authorization: explicit manual
E2E maindispatch and its administrator/runner guard remain unchanged. - Dependencies: none.
- Error handling/logging: no new sensitive output or failure suppression outside the named automatic selection.
- Cryptography/data protection: not applicable.
- Secure configuration: automatic planning, deterministic validation, advisor normalization, and dynamic credential-free discovery share one predicate and omit only
jetson-nvmap-gpu. - Security tests: focused tests prove the ordinary inventory still sees Jetson, the PR plan omits it while retaining other risk-selected jobs, and required/optional/dynamic advisor paths cannot reintroduce it.
- System/sandbox security: no runner, workflow credential, sandbox, or host policy is changed.
Cross-issue sweep: #8142 is the formal design/ownership track for restoring trusted Jetson execution, and #8099 remains the exact-head hardware-validation consumer. Please add Refs #8142 to the PR body so the temporary omission and its removal condition are connected to that accepted design work. This PR does not replace #8099's required manual Jetson evidence.
Summary
Automatic PR E2E planning and PR Review Advisor recommendations selected
jetson-nvmap-gpu, but the E2E workflow rejects that job unless an administrator confirms an online Jetson runner. This change omits only that job from both automatic surfaces until the Colossus-backed runner path can confirm runner availability; explicit manual dispatch remains available.Related Issue
Relates to #7610.
Changes
jetson-nvmap-gpufrom automatic gate selections, advisor deterministic context, and advisor recommendation allowlists while leaving the generic focused-job selector and explicit manual workflow dispatch unchanged.test/e2e/README.md.Type of Change
Quality Gates
Documentation Writer Review
docs-updatedb404713c5, reported no findings, and confirmed that automatic gate planning, advisor guidance, generic selector discovery, guarded manual dispatch, and the Colossus-backed restoration condition are consistent. The focused suite passed 107 tests; CLI type-checking, Biome, test-size, Markdown lint, and diff checks passed.DGX Station Hardware Evidence
scripts/prepare-dgx-station-host.shis unchanged.Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpx vitest run --project integration test/pr-e2e-gate.test.ts test/pr-e2e-gate-jetson-exclusion.test.ts test/e2e-recommendations.test.ts test/pr-review-advisor.test.tspassed 107 tests;npm run typecheck:cliandnpm run test-size:checkpassed.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)Signed-off-by: San Dang sdang@nvidia.com
Summary by CodeRabbit
Bug Fixes
Documentation