test(e2e): define native runtime activation qualification - #8062
test(e2e): define native runtime activation qualification#8062ericksoa wants to merge 11 commits into
Conversation
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Second-opinion E2E selections are advisory. They do not change the primary assessment or E2E / PR Gate. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: 2 warnings · 0 suggestionsWarningsWarnings do not block.
|
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
…cycle Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
cv
left a comment
There was a problem hiding this comment.
Reviewed commit ddb4e5766e in bottom-up stack order. This PR depends on draft PR #8069, which is not approval-ready. The qualification contract is behind the draft parent and its CLI and E2E checks fail. Review remains blocked until the parent is reconstructed or repaired, this branch is restacked on the accepted parent commit, and current CI, security, and documentation evidence passes for the resulting commit. No approval is granted for the current branch.
cv
left a comment
There was a problem hiding this comment.
Two architecture and security changes are required. Remove the dormant qualification subsystem or connect it to one accepted executable consumer that enforces the contract. At that trusted controller boundary, supply the expected repository, protected workflow, and PR head/base identities and verify the referenced run, job, and artifacts; self-reported internally consistent receipts are replayable. Add a rejection test for a valid receipt from the wrong head/base pair. Restack onto a passing parent and clear the failing E2E and CLI checks.
Summary
This PR adds a dormant, runtime-neutral activation qualification contract for a native container-runtime candidate. It makes the complete Podman release scope compile-time mandatory without registering Podman, changing production selection, or advertising support.
Related Issue
Part of #7744.
Changes
Type of Change
Quality Gates
Documentation Writer Review
docs-updatedtest/e2e/docs/NATIVE_RUNTIME_QUALIFICATION.mdand the native-runtime qualification note intest/e2e/docs/README.mdmatch the dormant implementation boundary, use the project terms, and make no support claim.DGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailabled70120a47.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)Signed-off-by: Aaron Erickson aerickson@nvidia.com