fix(hermes): repair v0.19 runtime migrations - #7849
Conversation
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughHermes configuration removes ChangesHermes runtime alignment
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant DockerBuild
participant HermesPatcher
participant HermesImage
participant SnapshotRestore
DockerBuild->>HermesPatcher: patch cron ledger and snapshot inventory
HermesPatcher->>HermesImage: write runtime/cron-executions.db paths
HermesImage->>SnapshotRestore: expose declared runtime ledger
SnapshotRestore-->>HermesImage: backup and restore SQLite ledger online
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 8e0bbe2 in the TypeScript / code-coverage/cliThe overall coverage in commit 8e0bbe2 in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: 1 warning · 0 suggestionsWarningsWarnings do not block.
|
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
ericksoa
left a comment
There was a problem hiding this comment.
Approve pending e2e green
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com> # Conflicts: # agents/hermes/start.sh # scripts/managed-gateway-control.py # test/e2e/live/mcp-bridge-hermes-lifecycle.ts # test/managed-gateway-control.test.ts
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-7849.docs.buildwithfern.com/nemoclaw |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/deployment/sandbox-hardening.mdx`:
- Line 11: Update the agent-variants metadata in sandbox-hardening.mdx to
include the applicable supported variants hermes and deepagents alongside
openclaw, ensuring generic NemoClaw sandbox hardening guidance is discoverable
for all covered products.
In `@docs/monitoring/monitor-sandbox-activity.mdx`:
- Line 13: Update the shared page declaration and session-state section in
monitor-sandbox-activity.mdx so Hermes does not receive OpenClaw-only
instructions. Wrap the session-state content around lines 60-75 with the
existing AgentOnly component for the openclaw variant, or replace it with valid
Hermes-specific instructions before retaining both variants in agent-variants.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f232a9a8-92b8-45b7-a09f-8c97638b19b4
📒 Files selected for processing (81)
.agents/skills/nemoclaw-contributor-update-docs/SKILL.md.agents/skills/nemoclaw-contributor-update-hermes/references/hermes-contract-map.mdagents/hermes/Dockerfileagents/hermes/manifest.yamlagents/hermes/patch-cron-execution-runtime.pyagents/hermes/start.shdocs/AGENTS.mddocs/CONTRIBUTING.mddocs/about/ecosystem-deepagents.mdxdocs/about/ecosystem-hermes.mdxdocs/about/ecosystem.mdxdocs/configure-agents/configure-agent-heartbeats.mdxdocs/configure-agents/understand-context-compaction.mdxdocs/deployment/gateway-lifecycle-authority.mdxdocs/deployment/install-openclaw-plugins.mdxdocs/deployment/sandbox-hardening.mdxdocs/get-started/quickstart-hermes.mdxdocs/get-started/quickstart-langchain-deepagents-code.mdxdocs/get-started/quickstart.mdxdocs/index.ymldocs/inference/configure-model-capabilities.mdxdocs/inference/declarative-agents-manifest.mdxdocs/inference/set-up-ollama.mdxdocs/inference/set-up-sub-agent.mdxdocs/inference/use-hermes-provider.mdxdocs/manage-sandboxes/add-channels-after-onboarding.mdxdocs/manage-sandboxes/backup-restore.mdxdocs/manage-sandboxes/enable-channels-during-onboarding.mdxdocs/manage-sandboxes/gateway-lifecycle-control.mdxdocs/manage-sandboxes/install-plugins-hermes.mdxdocs/manage-sandboxes/manage-messaging-channels.mdxdocs/manage-sandboxes/messaging-channels.mdxdocs/manage-sandboxes/runtime-controls.mdxdocs/manage-sandboxes/set-up-discord.mdxdocs/manage-sandboxes/set-up-microsoft-teams.mdxdocs/manage-sandboxes/set-up-slack.mdxdocs/manage-sandboxes/set-up-telegram.mdxdocs/manage-sandboxes/set-up-wechat.mdxdocs/manage-sandboxes/set-up-whatsapp.mdxdocs/monitoring/manage-deepagents-trace-export.mdxdocs/monitoring/monitor-sandbox-activity.mdxdocs/monitoring/set-up-deepagents-trace-export.mdxdocs/monitoring/understand-deepagents-trace-export.mdxdocs/monitoring/verify-deepagents-trace-export.mdxdocs/network-policy/configure-raw-tls-passthrough.mdxdocs/network-policy/explain-network-policy-to-agents.mdxdocs/network-policy/integration-policy-examples.mdxdocs/network-policy/set-up-gmail-with-an-app-password.mdxdocs/reference/commands.mdxdocs/reference/enterprise-readiness.mdxdocs/resources/engineer-agentic-documentation.mdxdocs/security/configure-corporate-ca-trust.mdxdocs/security/credential-rotation.mdxdocs/security/hermes-0.19.0-dependency-review.mddocs/security/openclaw-controls.mdxdocs/security/openshell-0.0.71-gateway-auth-review.mdxdocs/security/tcb-boundary.mdxscripts/managed-gateway-control.pyscripts/sync-agent-variant-docs.mtssrc/lib/actions/sandbox/process-recovery.test.tssrc/lib/actions/sandbox/process-recovery.tssrc/lib/actions/sandbox/status-flow.test.tssrc/lib/actions/sandbox/status-lookup-rendering.tssrc/lib/actions/sandbox/status-snapshot-recovery.test.tssrc/lib/actions/sandbox/status-snapshot.tstest/check-docs-published-routes.test.tstest/cli/sandbox-status-json.test.tstest/e2e/live/dashboard-remote-bind-env.tstest/e2e/live/dashboard-remote-bind.test.tstest/e2e/live/mcp-bridge-hermes-lifecycle.tstest/e2e/support/dashboard-remote-bind-env.test.tstest/hermes-cron-execution-runtime-patch.test.tstest/hermes-dependency-review.test.tstest/hermes-discord-recovery-permissions.test.tstest/hermes-final-image-layout.test.tstest/hermes-start.test.tstest/hermes-state-ledger-snapshot.test.tstest/managed-gateway-control.test.tstest/snapshot-stale-directory-restore.test.tstest/state-dir-guard.test.tstest/sync-agent-variant-docs.test.ts
| keywords: ["nemoclaw sandbox hardening", "container security", "docker capabilities", "process limits"] | ||
| content: | ||
| type: "reference" | ||
| agent-variants: ["openclaw"] |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Publish sandbox hardening guidance for every applicable variant.
This page describes generic NemoClaw sandbox security controls rather than OpenClaw-specific behavior. Unless there is an explicit scope decision, include hermes and deepagents in agent-variants so those users can access the hardening guidance.
As per path instructions, documentation variant scope must reflect the actual supported product surface.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/deployment/sandbox-hardening.mdx` at line 11, Update the agent-variants
metadata in sandbox-hardening.mdx to include the applicable supported variants
hermes and deepagents alongside openclaw, ensuring generic NemoClaw sandbox
hardening guidance is discoverable for all covered products.
Source: Path instructions
| type: "how_to" | ||
| skill: | ||
| priority: 10 | ||
| agent-variants: ["openclaw", "hermes"] |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Do not expose OpenClaw-only session instructions on the Hermes page.
This declaration publishes the page for Hermes, but the unguarded session-state section at Lines 60-75 documents OpenClaw-only paths and behavior. Wrap that section in <AgentOnly variant="openclaw"> or provide Hermes-specific instructions before declaring both variants.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/monitoring/monitor-sandbox-activity.mdx` at line 13, Update the shared
page declaration and session-state section in monitor-sandbox-activity.mdx so
Hermes does not receive OpenClaw-only instructions. Wrap the session-state
content around lines 60-75 with the existing AgentOnly component for the
openclaw variant, or replace it with valid Hermes-specific instructions before
retaining both variants in agent-variants.
Source: Path instructions
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/e2e/support/mcp-bridge-hermes-lifecycle.test.ts`:
- Around line 38-45: Update the test case around assertHermesReloadRollback to
assert the specific rejection message or error pattern expected when
sandboxWithInspectionState("current") is rejected, rather than accepting any
thrown error. Preserve the existing hermes-e2e and MCP endpoint setup while
matching the observable contract for the current state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3169e926-16a3-4165-a766-1645d91fc8bd
📒 Files selected for processing (2)
test/e2e/live/mcp-bridge-hermes-lifecycle.tstest/e2e/support/mcp-bridge-hermes-lifecycle.test.ts
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
|
Exact-head protected E2E blocker at I am not submitting a Changes Requested review and I am not modifying the contributor branch. Please diagnose this exact failure (or attach evidence that it is unrelated), then rerun the protected gate on the resulting quiet exact head. |
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
|
The exact-head protected rerun still blocks approval at The selected Evidence: https://github.com/NVIDIA/NemoClaw/actions/runs/30506251272/job/90756659597 The latest tool-name/parsing adjustment is therefore not sufficient for the protected Hermes lifecycle. I will re-review the next quiet revision; I am leaving this as a plain review comment, not Changes Requested. |
prekshivyas
left a comment
There was a problem hiding this comment.
Approved. The remaining observations are non-blocking test-hardening opportunities. Please wait for the exact-head E2E / PR Gate to pass before merging.
<!-- markdownlint-disable MD041 --> ## Summary Add the canonical pre-tag release entry for NemoClaw v0.0.98. The dated entry records the user-visible changes merged after v0.0.97 and links each release theme to its published documentation. ## Changes - Add `docs/changelog/2026-07-29.mdx` with the exact `## v0.0.98` release heading. - Summarize Hermes 0.19, Deep Agents Code automation and skill safety, readiness diagnostics, lifecycle recovery, uninstall behavior, messaging conflicts, dependency hardening, and bounded diagnostics. - Use the parser-safe MDX SPDX comment and root-absolute routes for published OpenClaw, Hermes, and Deep Agents documentation. ### Source summary - [#7849](#7849) -> `docs/changelog/2026-07-29.mdx`: Record the Hermes 0.19 runtime migration repairs for cron state, dashboard seeding, and MCP naming. - [#7662](#7662) -> `docs/changelog/2026-07-29.mdx`: Record bounded gateway and Docker subprocess diagnostics. - [#7850](#7850) -> `docs/changelog/2026-07-29.mdx`: Record verified no-clobber Deep Agents Code skill installation. - [#7848](#7848) -> `docs/changelog/2026-07-29.mdx`: Record post-reboot delivery-chain recovery for visible OpenClaw sandboxes. - [#7831](#7831) -> `docs/changelog/2026-07-29.mdx`: Record OpenShell gateway-state preservation during uninstall. - [#7827](#7827) -> `docs/changelog/2026-07-29.mdx`: Record the removal of upstream test sources from published Hermes images. - [#7775](#7775) -> `docs/changelog/2026-07-29.mdx`: Record the blocking diagnostic for unsupported `DOCKER_HOST` values. - [#7833](#7833) -> `docs/changelog/2026-07-29.mdx`: Record reviewed Python dependency baselines for Hermes and Deep Agents Code images. - [#7771](#7771) -> `docs/changelog/2026-07-29.mdx`: Record the managed Hermes Agent 0.19.0 upgrade. - [#7811](#7811) -> `docs/changelog/2026-07-29.mdx`: Record fail-closed messaging channel conflict handling. - [#7797](#7797) -> `docs/changelog/2026-07-29.mdx`: Record the managed non-interactive Deep Agents Code JSON envelope. - [#7782](#7782) -> `docs/changelog/2026-07-29.mdx`: Record the storage-remediation readiness capability. - [#7784](#7784) -> `docs/changelog/2026-07-29.mdx`: Record the 120-second OpenShell readiness budget for sandbox recreation. - [#7810](#7810) -> `docs/changelog/2026-07-29.mdx`: Record rejection of stale Deep Agents Code security inventories. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [x] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates - [ ] Tests added or updated for changed behavior - [x] Existing tests cover changed behavior — justification: `test/changelog-docs.test.ts` validates the native changelog contract, including the version heading, MDX SPDX comment, and published routes. - [ ] Tests not applicable — justification: - [x] Docs updated for user-facing behavior changes - [ ] Docs not applicable — justification: - [ ] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [ ] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Documentation Writer Review - [x] Documentation writer subagent reviewed the completed changes - Result: `docs-updated` - Evidence: `docs/changelog/2026-07-29.mdx` was reviewed against `docs/CONTRIBUTING.md` and `WRITING.md` for release meaning, terminology, structure, voice, sentence form, MDX structure, published routes, and code-sample presentation. The changelog contract passed 6 tests. The docs build completed with 0 errors and 2 existing Fern warnings. - Agent: Codex CLI <!-- docs-review-head-sha: e3221d1 --> <!-- docs-review-agents-blob-sha: c052d60 --> ## DGX Station Hardware Evidence - [ ] Tested on DGX Station - Tested commit: Not applicable. `scripts/prepare-dgx-station-host.sh` is unchanged. - Station profile/scenario: Not applicable. - Result: Not applicable. - Supporting evidence: Not applicable. ## Verification - [x] PR description includes a `Signed-off-by:` line and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run validate:pr` passed after refreshing `origin/main` when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — `npx vitest run test/changelog-docs.test.ts` passed 6 tests. - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — command/result: Not run for this documentation-only change. - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) — The build completed with 0 errors and 2 existing Fern warnings. - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) — Native changelog entries use the required parser-safe MDX SPDX comment and do not use frontmatter. --- Signed-off-by: San Dang <sdang@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added managed Hermes upgrades with verified releases, version reporting, and preserved configuration contracts. - Improved Deep Agents Code JSON output and skill installation behavior. - Added clearer Docker host and system readiness reporting. - Improved post-reboot delivery recovery and sandbox readiness timing. - **Bug Fixes** - Preserved gateway state when uninstalling with `--keep-openshell`. - Prevented conflicting messaging credentials from blocking onboarding and rebuilds. - Improved gateway diagnostics, dependency security, runtime filesystem protection, and evidence handling. - **Documentation** - Published the v0.0.98 release notes. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- markdownlint-disable MD041 --> ## Summary `nemoclaw shields down` replaced the complete live OpenShell policy and dropped generated policy entries for registered Model Context Protocol (MCP) servers. This change reconciles only exact NemoClaw-managed MCP entries during Shields transitions, so a surviving server remains reachable while removed servers stay removed. Stacked on prerequisite #8130, which makes Shields deadline recovery serialize with lifecycle mutations without signaling the lock owner, this focused fix supersedes the MCP portion of #7980. ## Related Issue Fixes #7952 ## Changes - Prove managed MCP policy ownership from exact agreement between the sandbox registry, committed generated-policy record, and live gateway policy. - Save the owned MCP key manifest with the Shields snapshot, remove snapshot-time managed entries during restoration, and overlay only current exact entries. - Fail closed on ambiguous, stale, incomplete, malformed, or legacy ownership during manual transitions. At an expired deadline, omit unproven managed MCP entries and audit the omission instead of extending the Shields-down window. - Preserve current managed MCP entries when building the permissive runtime policy, while rejecting an unreadable or ambiguous live policy. - Clean staged runtime policy files across early failure paths. - Restore the Hermes live regression assertions at the actual failure boundary and around the unrelated server lifecycle. - Document MCP policy reconciliation for manual and automatic restoration. ## Failure Timing and Hermes Upgrade Context The original journey had a hidden Shields lifecycle between the first successful call to server A and the later lifecycle for server B: 1. Run `shields up`. 2. Restart the Hermes gateway. 3. Run `shields down`. 4. Exercise the configuration rollback path. 5. Add and remove B. 6. Call A. Boundary instrumentation recorded in #7952 showed that A remained healthy through Shields up and the gateway restart. It became unusable immediately after Shields down, which dropped A's generated MCP policy. The later failure after B was removed was only where the test noticed the already-broken route; B removal was a misleading correlation. This surfaced during the Hermes upgrade work because new coverage and upgrade repairs landed nearly back-to-back: - #7761 added the Hermes MCP helper containing Shields up, gateway restart, Shields down, and rollback. Its verification collected and imported the live target but did not run the complete live E2E. - #7771 upgraded Hermes the next day, but its selected E2Es skipped the `mcp-bridge` target. - #7849 repaired Hermes 0.19 migrations and updated MCP tool naming, allowing the live test to progress far enough to expose the later failure. - #7866 moved the explicit `mcp restart A` before the first post-removal call. Restart reapplied A's generated policy and masked the missing-policy state. The corrected regression order is: 1. Run `shields up`. 2. Restart the Hermes gateway. 3. Run `shields down`. 4. Call A immediately. 5. Exercise the configuration rollback path. 6. Add B, prove the DNS-rebinding connection is denied, remove B, and verify that A's managed policy is unchanged while B's policy is gone. 7. Call A before the later explicit restart. 8. Capture the authenticated rediscovery offset. 9. Run `mcp restart A` without resupplying the secret. 10. Call A and verify authenticated rediscovery. Whole-policy Shields replacement and the filesystem-only runtime merge predate the Hermes upgrade. This is a latent NemoClaw Shields policy-composition defect detected by expanded Hermes regression coverage, not a Hermes upgrade regression. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [x] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates - [x] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [ ] Tests not applicable — justification: - [x] Docs updated for user-facing behavior changes - [ ] Docs not applicable — justification: - [x] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [x] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: Independent exact-head Codex security review passed all nine categories at `18039569796d6ac7604de032edb7abf84f2c73c4`; no findings. - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Documentation Writer Review - [x] Documentation writer subagent reviewed the completed changes - Result: `docs-updated` - Evidence: Reviewed `docs/manage-sandboxes/runtime-controls.mdx` and `docs/reference/commands.mdx`, all rendered guide variants, changed operator-facing text, comments, test titles, and the Hermes E2E chronology. Verified claims against source, issue #7952, and PRs #7761, #7771, #7849, and #7866. `npm run docs` completed with 0 errors and 2 existing Fern warnings. - Agent: Codex Desktop <!-- docs-review-head-sha: 1803956 --> <!-- docs-review-agents-blob-sha: 3dd7c24 --> ## DGX Station Hardware Evidence - [ ] Tested on DGX Station - Tested commit: Not applicable; `scripts/prepare-dgx-station-host.sh` is unchanged. - Station profile/scenario: Not applicable. - Result: Not applicable. - Supporting evidence: Not applicable. ## Verification - [x] PR description includes a `Signed-off-by:` line and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run validate:pr` passed after refreshing `origin/main` when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: Focused CLI 123/123, integration 11/11, E2E support 13/13, `npm run typecheck:cli`, `npm run checks:repository`, test-size guardrail, E2E semantic phase plans, and serial `npm run test:changed` 674/674 passed. - [x] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — command/result: [Standard PR CI run 30824992396](https://github.com/NVIDIA/NemoClaw/actions/runs/30824992396) passed. One inherited 50 ms lifecycle-lock assertion timing flake passed on the failed-job rerun without a code change. - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) `npm run docs` passed with 0 errors and 2 existing Fern warnings, so the warning-free checkbox remains unchecked. No new documentation pages were added. Trusted E2E [run 30826792180](https://github.com/NVIDIA/NemoClaw/actions/runs/30826792180) passed all 10 selected checks: cloud inference, cloud onboard, security posture, inference routing, MCP bridge, MCP bridge dev, network policy, onboard repair, onboard resume, and OpenShell credential-generation window. The primary review advisor reported no findings. Nemotron completed after retrying a protocol-only failure; its one test warning requested the exact transition/state ownership-mismatch deadline regression already present in `src/lib/shields/policy-transition.test.ts`, which passed. --- Signed-off-by: Julie Yaunches <jyaunches@nvidia.com> Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Summary
Hermes 0.19 introduced deterministic runtime regressions after
v0.0.97: dashboard seed-marker drift, an unsupported blanket reasoning-effort request, and a mutable cron execution ledger inside the sealed cron job-definition directory. This change aligns the reviewed configuration contracts and relocates only mutable cron execution history into the writable runtime boundary while keeping cron job definitions sealed.The trusted exact-head E2E also exposed a stale Hermes MCP fixture: Hermes 0.19 names native MCP tools as
mcp__server__tool, but the fixture still queried the Hermes 0.18 single-underscore name and accepted an echoed search query as a match. The fixture now uses the v0.19 name and requires an exact structural match before progressing.Changes
runtime/cron-executions.db.gatewayandruntimeboundaries during restart while preservingcronasroot:sandboxwith mode0755.mcp__server__toolname and fail closed unless discovery and schema responses structurally identify the exact deferred tool.Type of Change
Quality Gates
8e0bbe24aagainst base and merge based52d4599a; all categories passed with no findings. The final delta is test-only and strengthens fail-closed MCP fixture validation.Documentation Writer Review
docs-updateddocs/manage-sandboxes/backup-restore.mdxdocuments the relocated cron ledger and named-profile snapshot limitation.docs/security/hermes-0.19.0-dependency-review.mddocuments the restart regression, protectedcrondirectory, writableruntimeboundary, and Hermes v0.19mcp__server__toolnaming. The final test-only delta aligns the fixture with that documented naming and requires an exact structural discovery match; no additional user-facing documentation is required.DGX Station Hardware Evidence
Trusted E2E Failure and Fix
The approved trusted run for prior exact head
cdd62f906passed Bedrock-compatible Anthropic with Hermes and both Hermes inference-switch scenarios, but failed MCP bridge (Hermes). This is a deterministic fixture regression, not a flake or production MCP failure. PR #7771 upgraded Hermes to 0.19; upstream commite01f58ff1changed native MCP names tomcp__server__tool. The fixture retainedmcp_fake_fake_echo, and its substring assertion mistook the echoed query for a discovery match before callingtool_describewith the nonexistent legacy name.Exact head
8e0bbe24acorrects the tool name, requiresmatches[].nameto equal the deferred name, validates the exact described schema, and adds an echoed-query-with-empty-matches regression test. A new exact-head trusted E2E verdict is required before merge.Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailable8e0bbe24a,npm exec -- vitest run test/mcp-bridge-servers.test.tspassed all 10 tests after normal hooks;npm run typecheck, targeted Biome checks,git diff --check, andnpm run checks:repositorypassed.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result: Exact-head GitHub CI is in progress.npm run docsbuilds without warnings (doc changes only) — result: exact-head build completed with 0 errors and 2 existing Fern warnings.Signed-off-by: Julie Yaunches jyaunches@nvidia.com