chore(validation): clarify local validation command names - #7836
Conversation
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Remy the Refactoror <jmyaunch@gmail.com>
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 9303fd6 in the TypeScript / code-coverage/cliThe overall coverage in commit 9303fd6 in the Show a code coverage summary of the most impacted files.
Updated |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe PR makes ChangesValidation command routing
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
🌿 Preview your docs: https://nvidia-preview-pr-7836.docs.buildwithfern.com/nemoclaw |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.pre-commit-config.yaml:
- Around line 170-174: Add the repository root package.json to the files matcher
for the repository-checks hook in .pre-commit-config.yaml, preserving the
existing checks:repository command and other match patterns.
In `@CONTRIBUTING.md`:
- Around line 357-358: Update CONTRIBUTING.md lines 357-358 to place git fetch
origin main before npm run validate:pr and require rerunning validation after
the refresh; make the same ordering change in
.agents/skills/nemoclaw-contributor-onboard-messaging-channel/SKILL.md lines
108-109, and update .github/PULL_REQUEST_TEMPLATE.md line 49 to state that
origin/main must be refreshed before checking the fallback command.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e054f89c-c8a6-4a0c-b408-579de1110a72
📒 Files selected for processing (15)
.agents/skills/nemoclaw-contributor-create-pr/SKILL.md.agents/skills/nemoclaw-contributor-onboard-messaging-channel/SKILL.md.agents/skills/nemoclaw-maintainer-day/SALVAGE-PR.md.agents/skills/nemoclaw-maintainer-day/TEST-GAPS.md.github/PULL_REQUEST_TEMPLATE.md.pre-commit-config.yamlAGENTS.mdCONTRIBUTING.mdci/source-architecture-budget.jsonci/source-shape-test-budget.jsondocs/AGENTS.mddocs/CONTRIBUTING.mdfern/AGENTS.mdpackage.jsontest/pr-workflow-contract.test.ts
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
wscurran
added
area: ci
3 participants
Summary
Routine pull-request validation now uses the explicit
validate:prcommand, custom repository checks usechecks:repository, and the broad baseline remainscheck.This PR replaces #7633 with signed, GitHub-verified commits because repository rules forbid repairing its unsigned published history.
Related Issue
Fixes #7550
Changes
src/lib/core/shell-quote.tsfan-in budget from 27 to the measured value of 26.Merged PR ci(e2e): retire legacy Brev source-install validation #7632 reduced the fan-in, and the existing source-architecture check protects this limit.
Type of Change
Quality Gates
Documentation Writer Review
docs-updatednpm run checksscope notice and refreshingorigin/mainbeforenpm run validate:pr; focused contract tests, the actual legacy alias, repository checks, normal hooks, and the docs build passed.DGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpm exec -- vitest run test/pr-workflow-contract.test.tspassed 21 tests;npm run checksprinted the migration/scope notice and passed; repository checks, source-shape, and test-title validation passed.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — local structural checks and plugin coverage passed; CLI coverage encountered unrelated host-environment and timeout failures, so CI remains authoritative.npm run docsbuilds without warnings (doc changes only)Signed-off-by: Remy the Refactoror jmyaunch@gmail.com
Signed-off-by: Julie Yaunches jyaunches@nvidia.com
Summary by CodeRabbit
New Features
Documentation
Tests