feat(mcp): add opt-in authenticated tool discovery - #7591
Conversation
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds opt-in ChangesMCP tool discovery
Estimated code review effort: 5 (Critical) | ~120 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant MCPBridgeStatus
participant SandboxRuntime
participant ManagedMCPServer
CLI->>MCPBridgeStatus: mcp status server --tools
MCPBridgeStatus->>SandboxRuntime: execute shared discovery runtime
SandboxRuntime->>ManagedMCPServer: initialize and tools/list
ManagedMCPServer-->>SandboxRuntime: paginated tool names
SandboxRuntime-->>MCPBridgeStatus: bounded discovery result
MCPBridgeStatus-->>CLI: render toolDiscovery status
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 7a0a432 in the TypeScript / code-coverage/cliThe overall coverage in commit 7a0a432 in the Show a code coverage summary of the most impacted files.
Updated |
|
🌿 Preview your docs: https://nvidia-preview-pr-7591.docs.buildwithfern.com/nemoclaw |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: 2 optional E2E recommendations
This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
tools/mcp-tool-discovery-runtime/install-reviewed-runtime.sh (1)
19-28: 🔒 Security & Privacy | 🔵 Trivial | 💤 Low valueUse
mktempinstead of a fixed/tmppath for the decoded CA.
$decodeduses a predictable, fixed filename. Usingmktempavoids a symlink/TOCTOU race on a shared/tmpduring the build stage.🔒 Suggested fix
- decoded=/tmp/nemoclaw-mcp-runtime-ca.decoded + decoded=$(mktemp)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tools/mcp-tool-discovery-runtime/install-reviewed-runtime.sh` around lines 19 - 28, Replace the fixed /tmp path assigned to decoded in install-reviewed-runtime.sh with a securely created temporary file using mktemp, while preserving the existing base64 decode, awk extraction, and cleanup flow.test/mcp-tool-discovery-image-contract.test.ts (1)
16-27: 🎯 Functional Correctness | 🔵 Trivial | 🏗️ Heavy liftAssert the assembled-image contract, not Dockerfile text.
These assertions lock in exact instructions but do not prove the runtime is present or executable in an image. Exercise the built image and verify the canonical module emits the expected contract instead.
As per path instructions, “Prefer observable outcomes through the public boundary over source-text, private-shape, or mock-call assertions.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/mcp-tool-discovery-image-contract.test.ts` around lines 16 - 27, Replace the Dockerfile text assertions in the “MCP tool discovery image contract” test with an assembled-image integration check. Build or load each image represented by dockerfiles, execute the canonical mcp-tool-discovery module at runtimeRoot, and assert that it is present, executable, and emits the expected tool-discovery contract; avoid validating COPY or command strings directly.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/mcp-tool-discovery-image-contract.test.ts`:
- Around line 16-27: Replace the Dockerfile text assertions in the “MCP tool
discovery image contract” test with an assembled-image integration check. Build
or load each image represented by dockerfiles, execute the canonical
mcp-tool-discovery module at runtimeRoot, and assert that it is present,
executable, and emits the expected tool-discovery contract; avoid validating
COPY or command strings directly.
In `@tools/mcp-tool-discovery-runtime/install-reviewed-runtime.sh`:
- Around line 19-28: Replace the fixed /tmp path assigned to decoded in
install-reviewed-runtime.sh with a securely created temporary file using mktemp,
while preserving the existing base64 decode, awk extraction, and cleanup flow.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b5ec1e15-6793-4312-ad0c-217fc6312441
⛔ Files ignored due to path filters (1)
tools/mcp-tool-discovery-runtime/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (37)
Dockerfileagents/hermes/Dockerfileagents/langchain-deepagents-code/Dockerfiledocs/manage-sandboxes/manage-mcp-servers.mdxdocs/reference/commands.mdxscripts/check-dcode-profile-import-gate.shsrc/lib/actions/sandbox/mcp-bridge-contracts.tssrc/lib/actions/sandbox/mcp-bridge-render.tssrc/lib/actions/sandbox/mcp-bridge-resolution-probe-security.test.tssrc/lib/actions/sandbox/mcp-bridge-resolution-probe.tssrc/lib/actions/sandbox/mcp-bridge-runtime-command.tssrc/lib/actions/sandbox/mcp-bridge-status-resolution.test.tssrc/lib/actions/sandbox/mcp-bridge-status.tssrc/lib/actions/sandbox/mcp-bridge-tool-discovery.test.tssrc/lib/actions/sandbox/mcp-bridge-tool-discovery.tssrc/lib/actions/sandbox/mcp-bridge.tssrc/lib/actions/sandbox/mcp-tool-discovery-runtime.test.tssrc/lib/cli/public-display-mcp.test.tssrc/lib/cli/public-display-mcp.tssrc/lib/sandbox/build-context.tstest/e2e/live/mcp-bridge-servers.tstest/e2e/live/mcp-bridge-tool-discovery.tstest/e2e/live/mcp-bridge.test.tstest/e2e/support/live-vitest-invocation.test.tstest/langchain-deepagents-code-profile-build-gate.test.tstest/mcp-tool-discovery-image-contract.test.tstest/openclaw-final-image-layout.test.tstest/sandbox-build-context.test.tstools/e2e/live-vitest-invocation.mtstools/mcp-tool-discovery-runtime/build-runtime.tstools/mcp-tool-discovery-runtime/dependency-review.mdtools/mcp-tool-discovery-runtime/install-reviewed-runtime.shtools/mcp-tool-discovery-runtime/mcp-tool-discovery.tstools/mcp-tool-discovery-runtime/package.jsontools/mcp-tool-discovery-runtime/tool-discovery-core.tstools/mcp-tool-discovery-runtime/tsconfig.jsontsconfig.cli.json
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
<!-- markdownlint-disable MD041 --> ## Summary Add the canonical `docs/changelog/2026-07-25.mdx` release entry with the exact `## v0.0.96` heading. The entry reconciles all 90 first-parent commits since v0.0.95 with all 92 merged PRs in the live `v0.0.96` label ledger and groups the user-visible changes by operator journey. ## Changes - Add the parser-safe dated MDX changelog entry for v0.0.96 with root-absolute links to the focused user guides. - Source summary: - [#7194](#7194) -> `docs/changelog/2026-07-25.mdx`: Document persistent baseline network policy exclusions and their inspection, rebuild, and snapshot behavior. - [#7188](#7188), [#7427](#7427), and [#7546](#7546) -> `docs/changelog/2026-07-25.mdx`: Document DNS-backed HTTPS inference routing, keyless loopback endpoints, and provider-marker isolation. - [#7238](#7238) -> `docs/changelog/2026-07-25.mdx`: Document blueprint sandbox and provider identifier validation before state writes or OpenShell calls, with bounded terminal-safe rejection previews. - [#7319](#7319), [#7274](#7274), [#7528](#7528), [#7353](#7353), and [#7560](#7560) -> `docs/changelog/2026-07-25.mdx`: Document the managed default gateway service, onboarding readiness, and container-runtime identity safeguards. - [#7349](#7349), [#7498](#7498), [#7406](#7406), [#7196](#7196), [#7559](#7559), [#7421](#7421), [#7510](#7510), [#7295](#7295), and [#7565](#7565) -> `docs/changelog/2026-07-25.mdx`: Document gateway-scoped status, lifecycle diagnostics, managed MCP recovery, delete-edge safeguards, and fail-closed CLI prompt and command output. - [#7591](#7591) -> `docs/changelog/2026-07-25.mdx`: Document opt-in authenticated MCP tool-name discovery, its bounded and names-only contract, probe interaction, and rebuild requirement. - [#7305](#7305), [#7480](#7480), [#7471](#7471), [#7365](#7365), and [#7541](#7541) -> `docs/changelog/2026-07-25.mdx`: Document installer version checks, version-tag reporting, license guidance, WSL Ollama selection, and DGX Station vLLM detection. - [#7482](#7482), [#7466](#7466), [#7208](#7208), [#7434](#7434), and [#7586](#7586) -> `docs/changelog/2026-07-25.mdx`: Document Ollama resource details, reasoning precedence, Hermes onboarding behavior, and preserved managed Hermes BuildKit failures. - [#6830](#6830), [#7492](#7492), [#7563](#7563), and [#7582](#7582) -> `docs/changelog/2026-07-25.mdx`: Document the authoritative OpenClaw production lock, fixed managed-image dependencies, immutable Hermes base adoption, and Hermes image-size reduction. - [#7505](#7505), [#7530](#7530), [#7547](#7547), [#7508](#7508), [#7548](#7548), [#7549](#7549), [#7537](#7537), [#7534](#7534), [#7515](#7515), [#7511](#7511), [#7551](#7551), [#7562](#7562), [#7575](#7575), [#7496](#7496), [#7594](#7594), [#7595](#7595), and [#7599](#7599) -> `docs/changelog/2026-07-25.mdx`: Summarize release validation, transient and bounded dispatch reconciliation, exact pre-tag qualification, identity revalidation, npm-audit retry, sharding, image reuse, timeout, telemetry, and workflow-hardening changes. - Reconciled without separate changelog prose: - [#7539](#7539), [#7526](#7526), [#7507](#7507), [#7506](#7506), [#7519](#7519), [#7516](#7516), [#7396](#7396), [#7254](#7254), [#7583](#7583), [#7596](#7596), and [#7598](#7598): Test-harness or fixture-only changes. - [#7403](#7403), [#7161](#7161), [#6877](#6877), [#7531](#7531), [#7525](#7525), [#7522](#7522), [#7536](#7536), [#7552](#7552), [#7566](#7566), [#7553](#7553), [#7561](#7561), [#7577](#7577), [#7569](#7569), [#7585](#7585), [#7584](#7584), [#7592](#7592), [#7580](#7580), [#7571](#7571), [#7517](#7517), [#7589](#7589), [#7402](#7402), [#7558](#7558), [#7544](#7544), and [#7601](#7601): Dependency, internal recovery, validation, contributor-workflow, E2E optimization, telemetry, or CI trust changes with no separate user-facing release claim. - [#7556](#7556), [#7573](#7573), [#7576](#7576), and [#7578](#7578): Experimental repository-maintainer conflict automation with no canonical user documentation surface. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [x] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates - [ ] Tests added or updated for changed behavior - [x] Existing tests cover changed behavior — justification: `test/changelog-docs.test.ts` validates dated changelog structure, version headings, and published links. - [ ] Tests not applicable — justification: - [x] Docs updated for user-facing behavior changes - [ ] Docs not applicable — justification: - [ ] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [ ] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Documentation Writer Review - [x] Documentation writer subagent reviewed the completed changes - Result: `docs-updated` - Evidence: Reviewed `docs/changelog/2026-07-25.mdx` at exact head `0f5dedb47` against 90 first-parent release commits and 92 merged PRs labeled `v0.0.96`. Verified parser-safe MDX SPDX, the exact version heading, literal CLI names, writing style, skip terms, all 20 root-absolute published links, and the accepted #7591 opt-in authenticated discovery bounds. #7544, #7599, and #7601 remain internal or CI-only release-ledger entries. Changelog tests passed 6/6, the docs build passed with 0 errors and two pre-existing Fern warnings, and `npm run check:diff` plus the final diff check passed. - Agent: Codex Desktop documentation-writer subagent <!-- docs-review-head-sha: 0f5dedb --> <!-- docs-review-agents-blob-sha: be20a09 --> ## DGX Station Hardware Evidence - [ ] Tested on DGX Station - Tested commit: - Station profile/scenario: - Result: - Supporting evidence: ## Verification - [x] PR description includes a `Signed-off-by:` line and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run check:diff` passed when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — `npx vitest run test/changelog-docs.test.ts`: 6/6 passed. - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — command/result: Not applicable to this prose-only changelog entry. - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) — the build passed with 0 errors and 2 existing Fern warnings; the published-route check passed. - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) — native changelog files use the required parser-safe MDX SPDX comment and no frontmatter. --- Signed-off-by: Carlos Villela <cvillela@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Persistent network policy exclusions with consistent restore/exclusion reporting across rebuilds/snapshots. * Opt-in MCP tool discovery via `mcp status --tools` with bounded, redacted authenticated traffic. * Improved HTTPS inference switching for custom endpoints and refreshed onboarding/model menu details. * Refined OpenShell gateway defaults for port `8080`, including more reliable readiness checks. * **Bug Fixes** * Prevent incorrect provider/model restoration after compatible-provider update failures. * Preserve managed MCP state after exec loss and tighten gateway/doctor status scoping. * **Tests** * Stronger, fail-closed release validation with hardened evidence/artifact handoff and bounded timeouts/retries. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com> Co-authored-by: Prekshi Vyas <prekshiv@nvidia.com>
<!-- markdownlint-disable MD041 --> ## Summary Fix managed MCP tool discovery when a compliant Streamable HTTP server returns an SSE response media type with case variation or parameters. Upgrade the official MCP SDK to its parsed media-type implementation and make the regression session part of every reviewed runtime image build. This replaces #7748 with the same patch on current `main`; the published branch could not be rebased because repository rules forbid force-pushes. ## Related Issue Fixes #7726 ## Changes - Pin `@modelcontextprotocol/sdk` to `1.30.0`, refresh the exact lock, and record the adjacent-release, provenance, vulnerability, bundle, and license review. - Add a real `initialize` → `notifications/initialized` → `tools/list` → session cleanup fixture using `Text/Event-Stream; Charset=UTF-8`. - Stage and run that fixture in the shared reviewed runtime installer used by all agent image builds. This restores the generic Streamable HTTP/SSE contract accepted in #6901 and implemented in #7591. It does not add a provider-specific integration or compatibility layer. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates - [x] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [ ] Tests not applicable — justification: - [ ] Docs updated for user-facing behavior changes - [x] Docs not applicable — justification: This restores the existing documented Streamable HTTP discovery lifecycle without changing commands, flags, configuration, schemas, or supported integrations. - [x] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [x] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: Codex security review passed all nine repository categories; the credential placeholder, authorization, SSRF, policy, and final-image boundaries are unchanged, and the exact dependency pin is signature-, attestation-, license-, and audit-verified. - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Documentation Writer Review - [x] Documentation writer subagent reviewed the completed changes - Result: `no-docs-needed` - Evidence: Existing docs already describe Streamable HTTP discovery generically. This restores standards-compliant handling of a valid response media type and changes no command, flag, configuration, workflow, supported protocol, or documented user contract. Changelog work remains part of separate pre-tag release preparation. - Agent: Codex Desktop `/root/replacement_docs_review` <!-- docs-review-head-sha: 646d377 --> <!-- docs-review-agents-blob-sha: be20a09 --> ## DGX Station Hardware Evidence - [ ] Tested on DGX Station - Tested commit: - Station profile/scenario: - Result: - Supporting evidence: ## Verification - [x] PR description includes a `Signed-off-by:` line and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run check:diff` passed when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — reviewed-runtime session test (1 passed), CLI runtime tests (12 passed), build-context/image-contract tests (15 passed), runtime and CLI typechecks, bundle allowlist/license generation, zero-vulnerability production audit, 98 verified registry signatures, and 11 verified attestations. - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — command/result: - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Charan Jagwani <cjagwani@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Improved MCP tool discovery compatibility with case-variant SSE response media types. * Preserved session and protocol headers during tool discovery requests. * **Bug Fixes** * Updated the MCP runtime to ensure supported bundled content is included correctly. * **Tests** * Added coverage for SSE discovery, authentication, session cleanup, and request headers. * Runtime installation now runs its test suite as part of verification. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
Summary
Adds an opt-in
nemoclaw <sandbox> mcp status <server> --toolsdiagnostic that lists tool names through the configured MCP registration without invoking tools. This is a clean, linear replacement for the accumulated branch in #6904, rebuilt directly on currentmainaround the accepted #6901 trust boundary and current three-adapter architecture.Related Issue
Closes #6901
Changes
initializeand paginatedtools/listdiscovery with strict time, request, response, page, tool, cursor, and name limits.tools/call.mcporter; separate adapter clients would duplicate a security-sensitive protocol path.test/e2e/live/mcp-bridge.test.tsand the runtime/image contract tests protect the shared implementation.Type of Change
Quality Gates
6688fe6fc3fed997fe89e7322429c1f5505fe5d9across all nine repository security categories, including independent validation of the fail-closed evidence path, and found no issues. Exact-head advisors, CodeQL, secret scanning, CI, and protected E2E passed. This does not replace the fresh human security approval required before merge. Accepted trust contract: Add opt-in live MCP tool discovery to mcp status #6901 (comment)Documentation Writer Review
docs-updateddocs/manage-sandboxes/manage-mcp-servers.mdx,docs/reference/commands.mdx,test/e2e/README.md,tools/mcp-tool-discovery-runtime/dependency-review.md; reviewed terminology, structure, voice, security bounds, and code-sample presentation against accepted Add opt-in live MCP tool discovery to mcp status #6901;npm run docspassed with 0 errors.DGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpm run typecheck:cli,npm run check:diff, runtime/project boundary checks, andnpm run docspassed on exact head6688fe6fc3fed997fe89e7322429c1f5505fe5d9.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result: Exact-head PR CI passed static checks, build/typecheck, reviewed npm audit, installer integration, plugin tests, and all 8 CLI shards (https://github.com/NVIDIA/NemoClaw/actions/runs/30213491792); self-hosted CI passed both sandbox-image builds and all smoke/integration jobs (https://github.com/NVIDIA/NemoClaw/actions/runs/30213492138); protected E2E passed all 14 selected concrete jobs and controller evidence verification (https://github.com/NVIDIA/NemoClaw/actions/runs/30213967327; https://github.com/NVIDIA/NemoClaw/actions/runs/30213947255).npm run docsbuilds without warnings (doc changes only) — 0 errors; two pre-existing Fern warnings remain.Signed-off-by: Aaron Erickson aerickson@nvidia.com
Summary by CodeRabbit
mcp status --toolsto retrieve a point-in-time list of a server’s advertised MCP tool names, with bounded results and truncation when limits are reached.mcp statusJSON now includestoolDiscovery(ok,count,tools,truncated, optionaldetail);--toolscan run alongside--probe/--no-probewith consistent redaction.