ci(e2e): add runner comparison telemetry - #7394
Conversation
Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR Review Advisor — InformationalAdvisor assessment: Informational / high confidence Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: 4 optional E2E recommendations
This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
prekshivyas
left a comment
There was a problem hiding this comment.
Reviewed the incremental stacked diff at exact head a21a6cc against #7388 head 25a1775. Security PASS across all nine review categories. Telemetry is numeric/allowlisted and uses bounded private files; process names, argv, runner names, environment values, and secrets are excluded. The shared ZIP reader validates exact root names, duplicates, file type, encryption, entry/byte bounds, CRC, and never extracts to disk. Historical reads are limited to completed scheduled runs with read-only Actions access. Focused validation: 152 tests passed. No actionable findings. Parent #7388 and exact-SHA credentialed E2E remain required.
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
Addressed PRA-1 in signed commit 877e360: the artifact ZIP fixture now emits real method-8 deflated entries, verifies valid extraction, and verifies corrupt compressed data is rejected. The reader now catches decompression errors and returns null under its existing fail-closed contract. Fresh GitHub checks are running on the new head. |
|
Closing this implementation as superseded by #7399 for the core #7145 runner-comparison telemetry. I compared both current heads against #7145 and the merged #7100 work. #7399 is the safer canonical collector: it is based on main, has a focused five-execution scope, enforces trusted-main/alternate-checkout boundaries, uses bounded canonical JSONL with duplicate-key rejection, and has private-file plus symlink/hardlink defenses. Its ordinary checks are green and its review findings are resolved. This PR is currently stacked on #7388 rather than main, has failing static/CLI checks, and duplicates phase/resource collection already covered by #7100 and #7399. Merging or rebasing it wholesale would leave two evidence formats and two overlapping collectors. The unique ideas remain useful and should be preserved as narrow follow-ups under #7145 after the core collector lands:
Those follow-ups should consume the canonical #7399 artifact rather than retain this second collector. The branch and commits remain recoverable if targeted logic needs to be adapted later. |
Summary
This PR stacks on #7388 and leaves that PR unchanged. It adds diagnostic-only E2E telemetry so maintainers can distinguish queue delay from execution time, compare heavy-lane runner pressure, and see current semantic-test timing against a bounded nightly history without adding normal terminal-log noise or changing runner routing.
Related Issue
Related to #7145. Follow-up to #7388.
Changes
e2e-runtime-summary.jsonartifact and compare the current run with up to ten prior completed scheduled runs; manual runs and historical raw artifacts are excluded.artifact-zip.test.tsprotects the shared size, duplicate-entry, and exact-name contract.Type of Change
Quality Gates
test/e2e/README.md.DGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpx vitest run --project e2e-supportwith the 12 changed-boundary suites: 199 tests passednpm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — build stages passed, but the local all-project run was stopped after widespread unrelated timeout failures under concurrent load; CI is the broad gatenpm run docsbuilds without warnings (doc changes only)Signed-off-by: Charan Jagwani cjagwani@nvidia.com